Is RTL supported in PinLayout about pinlayout

[lucdion]

Hi @omegaes, sorry but currently PinLayout doesn't support RTL. But this would be easy to implement by adding more methods (ex: pin.start(), pin.end(), pin.before(of: UIView), pin.after(of: UIView), ...) and add an extra method pin.direction(LTR/RTL). I would be more than happy to review a PR. Anyway I'll add this to my TODO list.

[omegaes]

I did it, I will open a PR for it, I did it in this way, adding more start and end edges, start and end anchors, etc ..

[lucdion]

I'll check your PR, but I think that maybe another possibility would be to create another interface for RTL support, I'm little affraid/concerned that adding RTL to the existing API may impact its clearlyness. Another solution also would be to have a separate branch from it. But thanks for your future PR. Ah also, please note that this API would need to match my other project FlexLayout. This project purpose is to wrap Yoga's flexbox implementation, you can see this project still in development here https://github.com/lucdion/FlexLayout/tree/dev

[lucdion]

Hi @omegaes I though about it again a little bit, and finally I would finally add RTL support directly in the current API, not another protocol nor another branch. If you want to share your branch, I could also helps you to complete it.

My idea was to add a global method that would set the layout direction for all views, ex: PinLayoutDirection(.rtl).

It could be also possible to overwrite this default layout direction when layouting a view: ex: view.layoutDirection(.ltr).start(10).end(10). Do you think this method would be useful?

For method implementation, something like that should be nice, for example the `start(_ value: CGFloat):

    func start(_ value: CGFloat) -> PinLayout {
        func context() -> String { return "start(\(value))" }
        switch layoutDirection {
        case .ltr: setLeft(value, context)
        case .rtl: setRight(value, context)
        }
        return self
    }

What do you think about all this?

[omegaes]

I did an extension for PinLayout contains functions like:
`@discardableResult func marginStart(_ value: CGFloat) -> PinLayout {
if isLtr() {
marginLeft(value)
} else {
marginRight(value)
}
return self
}

@discardableResult func marginEnd(_ value: CGFloat) -> PinLayout {
    if isLtr() {
        marginRight(value)
    } else {
        marginLeft(value)
    }
    return self
}

so I implement isLtr in my way, reading language settings from defaults also I created extensions for AnchorList and EdgeList
var start : HorizontalEdge {
if (isLtr()) {
return left
} else {
return right
}
}

var end : HorizontalEdge {
    if (isLtr()) {
        return right
    } else {
        return left
    }
}`

`
var topStart : Anchor {
if (isLtr()) {
return topLeft
} else {
return topRight
}
}

var topEnd : Anchor {
    if (isLtr()) {
        return topRight
    } else {
        return topLeft
    }
}

var bottomStart : Anchor {
    if (isLtr()) {
        return bottomLeft
    } else {
        return bottomRight
    }
}

var bottomEnd : Anchor {
    if (isLtr()) {
        return bottomRight
    } else {
        return bottomLeft
    }
}

var startCenter : Anchor {
    if (isLtr()) {
        return leftCenter
    } else {
        return rightCenter
    }
}

var endCenter : Anchor {
    if (isLtr()) {
        return rightCenter
    } else {
        return leftCenter
    }
}

`

[lucdion]

@omegaes would you like to share with me your extension code, including your isltr method. I could integrate it.
Thanks

[omegaes]

sorry for delay, I hadn't no time to fork and open new PR, here is my code:
`
extension EdgeList {

func isLtr () -> Bool {
    if DataManager.shared.getUserLang()! == "ar" {
        return false
    }
    return true
}


var start : HorizontalEdge {
    if (isLtr()) {
        return left
    } else {
        return right
    }
}

var end : HorizontalEdge {
    if (isLtr()) {
        return right
    } else {
        return left
    }
}

}

extension AnchorList {

func isLtr () -> Bool {
    if DataManager.shared.getUserLang()! == "ar" {
        return false
    }
    return true
}


var topStart : Anchor {
    if (isLtr()) {
        return topLeft
    } else {
        return topRight
    }
}

var topEnd : Anchor {
    if (isLtr()) {
        return topRight
    } else {
        return topLeft
    }
}

var bottomStart : Anchor {
    if (isLtr()) {
        return bottomLeft
    } else {
        return bottomRight
    }
}

var bottomEnd : Anchor {
    if (isLtr()) {
        return bottomRight
    } else {
        return bottomLeft
    }
}

var startCenter : Anchor {
    if (isLtr()) {
        return leftCenter
    } else {
        return rightCenter
    }
}

var endCenter : Anchor {
    if (isLtr()) {
        return rightCenter
    } else {
        return leftCenter
    }
}

}

extension PinLayout {

func isLtr () -> Bool {
    if DataManager.shared.getUserLang()! == "ar" {
        return false
    }
    return true
}

@discardableResult func start() -> PinLayout {
    if isLtr() {
        left()
    } else {
        right()
    }
    return self
}

@discardableResult func end() -> PinLayout {
    if isLtr() {
        right()
    } else {
        left()
    }
    return self
}

@discardableResult func start(_ value: CGFloat) -> PinLayout {
    if isLtr() {
        left(value)
    } else {
        right(value)
    }
    return self
}

@discardableResult func end(_ value: CGFloat) -> PinLayout {
    if isLtr() {
        right(value)
    } else {
        left(value)
    }
    return self
}



@discardableResult func start(_ percent: Percent) -> PinLayout {
    if isLtr() {
        left(percent)
    } else {
        right(percent)
    }
    return self
}

@discardableResult func end(_ percent: Percent) -> PinLayout {
    if isLtr() {
        right(percent)
    } else {
        left(percent)
    }
    return self
}

@discardableResult func start(to edge: HorizontalEdge) -> PinLayout {
    if isLtr() {
        left(to : edge)
    } else {
        right(to : edge)
    }
    return self
}

@discardableResult func end(to edge: HorizontalEdge) -> PinLayout {
    if isLtr() {
        right(to : edge)
    } else {
        left(to : edge)
    }
    return self
}

@discardableResult func topStart(to anchor: Anchor) -> PinLayout {
    if isLtr() {
        topLeft(to : anchor)
    } else {
        topRight(to : anchor)
    }
    return self
}

@discardableResult func topEnd(to anchor: Anchor) -> PinLayout {
    if isLtr() {
        topRight(to : anchor)
    } else {
        topLeft(to : anchor)
    }
    return self
}

@discardableResult func topStart() -> PinLayout {
    if isLtr() {
        topLeft()
    } else {
        topRight()
    }
    return self
}

@discardableResult func topEnd() -> PinLayout {
    if isLtr() {
        topRight()
    } else {
        topLeft()
    }
    return self
}



@discardableResult func startCenter(to anchor: Anchor) -> PinLayout {
    if isLtr() {
        leftCenter(to : anchor)
    } else {
        rightCenter(to : anchor)
    }
    return self
}

@discardableResult func endCenter(to anchor: Anchor) -> PinLayout {
    if isLtr() {
        rightCenter(to : anchor)
    } else {
        leftCenter(to : anchor)
    }
    return self
}

@discardableResult func startCenter() -> PinLayout {
    if isLtr() {
        leftCenter()
    } else {
        rightCenter()
    }
    return self
}

@discardableResult func endCenter() -> PinLayout {
    if isLtr() {
        rightCenter()
    } else {
        leftCenter()
    }
    return self
}


@discardableResult func bottomStart(to anchor: Anchor) -> PinLayout {
    if isLtr() {
        bottomLeft(to : anchor)
    } else {
        bottomRight(to : anchor)
    }
    return self
}

@discardableResult func bottomEnd(to anchor: Anchor) -> PinLayout {
    if isLtr() {
        bottomRight(to : anchor)
    } else {
        bottomLeft(to : anchor)
    }
    return self
}

@discardableResult func bottomStart() -> PinLayout {
    if isLtr() {
        bottomLeft()
    } else {
        bottomRight()
    }
    return self
}

@discardableResult func bottomEnd() -> PinLayout {
    if isLtr() {
        bottomRight()
    } else {
        bottomLeft()
    }
    return self
}

@discardableResult func marginStart(_ value: CGFloat) -> PinLayout {
    if isLtr() {
        marginLeft(value)
    } else {
        marginRight(value)
    }
    return self
}

@discardableResult func marginEnd(_ value: CGFloat) -> PinLayout {
    if isLtr() {
        marginRight(value)
    } else {
        marginLeft(value)
    }
    return self
}

}
`

[lucdion]

@omegaes I've implemented RTL support, but not everything has been tested yet. Everything is in the branch https://github.com/mirego/PinLayout/tree/add_rtl_support

[lucdion]

@omegaes RTL support has been integrated in the master branch https://github.com/mirego/PinLayout/releases/tag/1.2.0