Each service mesh-specific lab should only load the respective Meshery adapter about service-mesh-labs

[leecalcote]

@devansh42 we're this close... 🙂 Please do take on this issue after your other PR merges.

[pottekkat]

So to fix this issue, we have to pass in the adapters to the one liner that pulls the shell script.

[devansh42]

Yes, I've started working on this issue, will make a PR against it.

[leecalcote]

Yes, I've started working on this issue, will make a PR against it.

You da man.

[welcome]

Thanks for opening this issue. A contributor will be by to give feedback soon. In the meantime, please review the Layer5 Community Welcome Guide and sure to join the community Slack.

[kaushambisharma]

I'd like to work on this issue.

[leecalcote]

@kaushambisharma I completely missed your comment until just now... Please fire away.

[devansh42]

@leecalcote
Here is a potential solution for this issue, In the lab, we're asking users to fetch the installation script, which automatically installs and starts meshery with default context which fetches all the available adapters.

Instead of doing this, We can create a separate installation file just for labs (like this), it will install mersheryctl and then will create a custom context relevant to the lab e.g. for consul lab it will fetch only consul adapter and then will start meshery with that context.

[leecalcote]

@devansh42, it's great to see this thought come forth. Any reason to not extend the current installer to support the use case of more granular choice of adapters? There is general need for this same flexibility beyond the service mesh labs use case. // @hexxdump @suhaniii

[devansh42]

After merging meshery/meshery#3498 , we can implement the solution.

[devansh42]

I think, we should re-open this issue, as labs are not updated with these changes yet, i.e. We still need to update the lab docs as well.

[pottekkat]

Yes we do. GitHub takes the "fixes" keyword seriously. Which is good 😄