Coder Social home page Coder Social logo

Comments (8)

eli-darkly avatar eli-darkly commented on May 26, 2024

Thanks for pointing this out. It's a reasonable request. One thing I'd change slightly would be to make it take a List<JsonElement> rather than a list of Objects; while this means that our API is dependent on Gson's classes, that's been our approach elsewhere in the SDK (i.e. in LDClient.allFlags and LDClient.jsonVariation) when we need to represent an arbitrary value and guarantee that it's a type that can be represented in JSON.

from java-server-sdk.

martinblaustein avatar martinblaustein commented on May 26, 2024

while this means that our API is dependent on Gson's classes

Having that into consideration then I believe it would be a good implementation.

Although the LDClient.allFlags actually forced us to import gson to be able to process the result, but it's a very generic dependency :)

from java-server-sdk.

eli-darkly avatar eli-darkly commented on May 26, 2024

We did basically the same thing for .NET, which is the other strongly-typed platform where we use a third-party JSON library. There's no equivalent in Go, so we just use interface{} there even though technically that doesn't guarantee that the value can be marshalled in JSON.

from java-server-sdk.

martinblaustein avatar martinblaustein commented on May 26, 2024

Do you think the new method will be implemented soon?
If not we will change the values in the launchdarkly app, as a temporary solution.

from java-server-sdk.

eli-darkly avatar eli-darkly commented on May 26, 2024

Should be fairly soon— I'll try for the first half of this week. It's a very simple change with no effect on the rest of the platform.

from java-server-sdk.

martinblaustein avatar martinblaustein commented on May 26, 2024

AMAZING!

from java-server-sdk.

eli-darkly avatar eli-darkly commented on May 26, 2024

This has been implemented in the 4.1.0 release. :)

from java-server-sdk.

martinblaustein avatar martinblaustein commented on May 26, 2024

@eli-darkly Great!

from java-server-sdk.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.