Coder Social home page Coder Social logo

Comments (2)

jjdevzinho avatar jjdevzinho commented on May 20, 2024 1

Another idea could be to leverage the toSearchableArray method that already exists in Scout. This method returns an array of the model's attributes that should be indexed.

Instead of creating a new getSearchableFields method, Scout could check if any of the keys returned by toSearchableArray were changed before reindexing the model. This would avoid the need to define the searchable fields in two places and make the reindexing process more efficient.

Here's an example of how this could work:

// Get the keys from the toSearchableArray method
$searchableFields = array_keys($model->toSearchableArray());

// Check if any of these fields were changed
foreach ($searchableFields as $field) {
    if ($model->isDirty($field)) {
        // If a searchable field was changed, reindex the model
        $model->searchable();
        break;
    }
}

This approach would require changes to the Scout core, but it could be a more efficient way to control when reindexing occurs.

Thank you for considering my suggestion and this additional idea.

from scout.

driesvints avatar driesvints commented on May 20, 2024

We'd very much appreciate PR's which could help with optimisation. For these PR's please also include the proper benchmarks. Thanks

from scout.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.