Comments (2)
Another idea could be to leverage the toSearchableArray method that already exists in Scout. This method returns an array of the model's attributes that should be indexed.
Instead of creating a new getSearchableFields method, Scout could check if any of the keys returned by toSearchableArray were changed before reindexing the model. This would avoid the need to define the searchable fields in two places and make the reindexing process more efficient.
Here's an example of how this could work:
// Get the keys from the toSearchableArray method
$searchableFields = array_keys($model->toSearchableArray());
// Check if any of these fields were changed
foreach ($searchableFields as $field) {
if ($model->isDirty($field)) {
// If a searchable field was changed, reindex the model
$model->searchable();
break;
}
}
This approach would require changes to the Scout core, but it could be a more efficient way to control when reindexing occurs.
Thank you for considering my suggestion and this additional idea.
from scout.
We'd very much appreciate PR's which could help with optimisation. For these PR's please also include the proper benchmarks. Thanks
from scout.
Related Issues (20)
- Method Laravel\Scout\Builder::withSearchParameters does not exist. HOT 7
- Typesense: Search throws exception -> fields is required HOT 5
- Typesense: Import exception not properly thrown HOT 1
- We need more operators in where clauses HOT 2
- Warn when using null driver HOT 1
- use scopeSearch to allow searching on relationships HOT 1
- Artisan scout commands not defined. HOT 1
- Add a fake() for scout HOT 4
- Exception when searching large datasets for common query using paginate HOT 12
- Searchable not sync to meilisearch with other index HOT 1
- Laravel 11 Support? HOT 1
- MongoDB Support HOT 1
- Typesense driver makes unnecessary api cals HOT 3
- Incorrect Total Count in Laravel Scout Pagination HOT 1
- paginate() + query() = wrong pagination HOT 2
- Scout import for large datasets fails after upgrading from 10.X to Laravel 11.X HOT 9
- Scout with Meilisearch, is sending all model data instead of just the specific data defined in the toSearchableArray() method. HOT 2
- Incorrect Total Count in Laravel Scout Pagination HOT 8
- Cannot save more than 1 item per collections HOT 4
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from scout.