->setIndent("\t") about pint

[nunomaduro]

I see. For now, we are going to keep this one aside. We revisit this if more people ask for it.

[robclancy]

I see. For now, we are going to keep this one aside. We revisit this if more people ask for it.

This right here is just very annoying. You claim to have a simplified drop in replacement yet you can't configure the main thing to do with code style. It shows once again that this should have been a preset instead of a new package, or at the very least a wrapper for a proper preset so you could use the single binary or the preset. Luckily in the JS world people just make esling plugins with their own rules (part of the reason for this package as well I guess is because php cs fixer is just not as good as eslint for this type of thing).

But FFS choosing indentation is a core fucking part of code style. Also there isn't actually "real" reasons to use spaces over tabs anymore. But there are for using tabs over spaces. prettier/prettier#7475 (comment)

Edit: not to mention this issue was closed because you don't even know how php cs fixer works. And then no re-opened when it's clear that this functionality is missing. So even if you aren't going to do this the issue should still be open.

[thyseus]

Something like:

{
    "preset": "psr12",
    "indent": "\t"
    "lineEnding": "\n",
    "rules": {
        "yoda_style": false
    }
}

[chrisreedio]

I really enjoyed test driving Pint but the only thing missing for me is the ability to use tabs instead of spaces.

I have a large number of repos that I manage and they all use tabs.

I completely understand the aforementioned points on less configuration is better but I would switch to Pint immediately if we could set this.

Thanks again for the hard work in bringing this open source package to the world!

[taylorotwell]

@robclancy I agree it probably has too much already 👍

[skch-dev]

+1
tabs, please 😄

[MartinPL]

Yes, please +1

[camiant]

+1
tabs with 2/4 size selectable, please 🙏🏻😊

[DeQuasar]

+1

[taylorotwell]

@robclancy I don't have a strong opinion on this issue; however, please read the first line of the Pint readme:

Laravel Pint is an opinionated PHP code style fixer for minimalists.

Opinionated. The whole point of Pint was to format things how Laravel internally formats things with as close to zero configuration as possible. Of course there are lots of knobs and levers that are probably "missing" compared to php-cs-fixer. That is literally the entire point of this package. Anyone is free to just use php-cs-fixer directly if Pint is too opinionated for them or doesn't have enough customization options.

[nunomaduro]

You should read this section: https://github.com/laravel/pint#rules. You see rules, and how to configure them here: https://mlocati.github.io/php-cs-fixer-configurator/.

[thyseus]

@nunomaduro thanks for your reply, unfortunately the Indentation and Line Ending is not a "rule" but a independent php-cs-fixer setting. I think laravel-pint is not yet able to set Indentation and Line Ending.

[nunomaduro]

You mean a custom fixer?

[thyseus]

This is my .php-cs-fixer.php:

<?php

$finder = PhpCsFixer\Finder::create()
	->in(__DIR__)
	->name('*.php')
	->name('*.inc')
    ->name('*.phtml')
    ->exclude('storage');

$config = new PhpCsFixer\Config();

return $config
	->setIndent("\t")
	->setLineEnding("\n")
	->setRules([
		'@PSR12'                        => true,
		'@PhpCsFixer'                   => true,
		'binary_operator_spaces'        => false, // keep left and right area of = sign untouched
		'yoda_style'                    => false,
// ...

As you can see, rules are set via setRules(). setIndent() and setLineEnding() are separate configuration methods that needs to be called in order to configure them. We need a way to pass these values via pint.json to the underlying php-cs-fixer in my opinion.

[miskith]

+1 please ... I may prepare PR, but I am currently really busy, so don't want to be promising :)

[genintho]

+1

[Alpha1337k]

+1

[axtg]

+1

[Stiropor]

+1

[wischerdson]

+1 please

[leandrodiogenes]

+1

[KaloyanYosifov]

+1 please

[danielemontecchi]

+1 🙏

[mrneatly]

+1

+1

[robclancy]

Then why even have configuration at all? No configuration would be better than a config with holes in it.

[johnbacon]

Likewise, @chrisreedio! We've turned to using jetstreamlabs/pinte, but relying on any third-party fork has its downsides.

Real life conflicts with best intentions sometimes. I'm personally A-OK with spaces, but I can't get my engineering leadership on board, so it's turned into a dealbreaker.

[alexandertsintsadze]

+1

maybe this should fix indent, but I'm not sure how to compile or test

[johnbacon]

jetstreamlabs/pinte isn't updated much, so I've added tab + EOL capabilities only as a fork at johnbacon/stout.