Decouple or allow overriding of Carbon about ideas

[scrubmx]

I have a trait that I use in my BaseModel class:

<?php

namespace App\Models\Traits;

use Jenssegers\Date\Date;

trait TranslatesDates
{
    /**
     * Return model date attributes as a Jenssegers\Date\Date instance.
     *
     * @override \Illuminate\Database\Eloquent\Model
     *
     * @param mixed $value
     * 
     * @return \Jenssegers\Date\Date
     */
    protected function asDateTime($value)
    {
        return new Date(parent::asDateTime($value));
    }
}

As far as I know is the easiest way.

[AdenFraser]

@rtconner Surely providing the opportunity to remove an 'already high memory' date/time handler would be beneficial, if you see it as such a problem?

[IsraelOrtuno]

Carbon already supports localization http://carbon.nesbot.com/docs/#api-localization

[AdenFraser]

I was under the impression that only worked with the Localization that was built into the package? I'm not sure if there are locales missing, but you certainly wouldn't be in a situation where you can adjust the strings for diffForHumans I'd expect?

[IsraelOrtuno]

I think you could set a Translator instance manually to Carbon but actually you are right, Carbon is not very opened to changes

[Mevrael]

Not a fan of Carbon but had no problems using it, however I agree it's, in times, complicated and should be bindable/injectable/replacable.

[AdenFraser]

I actually like Carbon a lot but there are instances where it would be nice to be able to extend / replace it for different purposes, but it seems baked pretty tightly, especially with Eloquent which is where you are most likely to be want to extend it I imagine.

[rtconner]

Man this just seems like it would make an already high memory date/time handling even bulkier.

[AdenFraser]

@taylorotwell What are your thoughts in regards to this?

If it's something that you think is a feasible improvement to the core, I'll set about putting together a PR.

[Jeroen-G]

See also this: https://hashnode.com/ama/with-taylor-otwell-cilmj90zh000k6t53il0rdgqp#cilx5el0u00m3gb53xbey9i1o

[AdenFraser]

Interesting @Jeroen-G, I shall start putting together a PR then

[taylorotwell]

Carbon has new maintainers now which may improve the quality / maintenance of the library going forward.