Should collection forPage() 0 return NULL ? about ideas

[vlakoff]

I think only positive values should be supported, as the others don't make much sense.

Also I think the ability you suggested to "paginate backwards" wouldn't be very useful, but may be source of confusion:

• not the same at taking the last page (with your example, {8,9,10} vs. {10})
• order of items: forward, backward?

On the other hand, I may suggest a method countPages which could be used as so:

$perPage = 16;

$numPages = $collection->countPages($perPage);

// first page
$collection->forPage(1, $perPage);

// last page
$collection->forPage($numPages, $perPage);

[chungth]

@vlakoff For current behavior, If I call 0 to return the lastPage. I can get the last page without count the $numPages

//last page 
$collection->forPage(0, $perPage);

[vlakoff]

Nope:

$collection = collect([1,2,3,4,5,6,7,8,9,10]);

// last page is #4 and contains [10]
$collection->forPage(4, 3);

// [8,9,10]
$collection->forPage(0, 3);

Also, this behavior is because internally array_slice is called with offset ($page - 1) * $perPage. So with page 1 we get offset 0 which is fine, but with page <= 0 we get a negative offset and that is unsuitable.

[chungth]

@vlakoff sorry I misunderstood here. You are right. The last page is 10 .
So I can not get the last page like that => Maybe It also makes us confused here.

[RahamSher]

Dear,@chungth I noob to laravel.Kindly guide me on collection forPage().And what its functionality.Is not it query from Model(DB).Means its load all the data atonce and gives us data on each request or something else.Kindly guide me.