Laravel 11 command choice test issue about framework

[driesvints]

No

[taylorotwell]

Seems that way? PRs welcome 🤘

[gmaccario]

@yourchocomate As I said, I was trying the example on the official documentation, which currently looks different compared to a week ago. I leave you the old version here https://web.archive.org/web/20240312151913/https://laravel.com/docs/11.x/console-tests

[yourchocomate]

Ahh!! I see.. That was a mistake from the doc🥸

[driesvints]

That's an odd one... I get the same thing. From what I can gather in the code I don't think it's possible to assert output after it's been asserted once.

[github-actions]

Thank you for reporting this issue!

As Laravel is an open source project, we rely on the community to help us diagnose and fix issues as it is not possible to research and fix every issue reported to us via GitHub.

If possible, please make a pull request fixing the issue you have described, along with corresponding tests. All pull requests are promptly reviewed by the Laravel team.

Thank you!

[gmaccario]

Thank you @driesvints for your reply. Is there currently any workaround?

[gmaccario]

OK thank you. So basically a command that contains a choice instruction is not testable right now?

[gcjbr]

I found the issue, but don't understand mockery enough to fix it.

Tried for a couple hours by failed :(

If anyone wants to give it a poke:

On PendingCommand we check for askQuestion types of commands and clean the expectedQuestions array as we go.

Same should be done for writeln type of commands.

The gist of it is, at the end of the assertions, PendingCommand will call run() and fail if any of the arrays if things you wanna very is not empty.

Verification is done previously by mockConsoleOutput(), as I meantioned.

Something like:

`

 $mock = Mockery::mock(OutputStyle::class.'[askQuestion, writeln]', [
        new ArrayInput($this->parameters), $this->createABufferedOutputMock(),
    ]);


    foreach ($this->test->expectedOutputSubstrings as $substring) {
        $mock->shouldReceive('writeln')
            ->once()
            ->with(Mockery::type('string'), Mockery::type('int'))
            ->andReturnUsing(function ($text) {
                return $text;
            });

    }`

If anyone try it they'll see where I got stuck with Mockery.

[yourchocomate]

@gmaccario Can you clarify what you are expecting or what should be th expected behaviour?

Cause the order you have provided can't be valid as,

you already expecting an exact output by clarifying expectsOutput('Your name is Taylor Otwell and you prefer PHP.')
again it would be unnecessary - also the assertion will not happen for doesntExpectOutput()

[gmaccario]

@yourchocomate I tried the example in the official documentation https://laravel.com/docs/11.x/console-tests

[yourchocomate]

@yourchocomate I tried the example in the official documentation https://laravel.com/docs/11.x/console-tests

Okay! But asserting expectsOutputToContain() after expectsOutput('some text') will lead to fail in test as you're already expecting for a specific output rather than a portion

[driesvints]

Just gonna close this one right now as not supported, sorry.