Feature Request: Manageable Envoy code: Add ability for a story to call another story, or to pass variables into tasks about envoy

[driesvints]

@story('s1')
    _task_s1
    common
@endstory

@story('s2')
    _task_s2
    common
@endstory

@task('_task_s1')
    file=".env_local"
@endtask

@task('_task_s2')
    file=".env_prod"
@endtask

@task('common')
    echo "file: {{ $file }}";
    #rm -rf {{ $file }}
@endtask

I don't understand here why you can't do this with the current functionality:

@task('common')
    echo "file: {{ $file }}";
    #rm -rf {{ $file }}
@endtask

envoy run common --file=".env_local"

Like I said: I'll need a very concrete example in order to know what it is that you're trying to achieve.

[driesvints]

I don't think this is possible but feel free to prove me wrong and provide a solution through a PR.

[connecteev]

@driesvints I believe everything is possible, the question is, is it feasible, and should we do it?Based on my very limited knowledge of the envoy source code, it may not be easy to call a story within another one (or a task within another one) given that the tasks are stored in an array.

However, isn't passing variables into Envoy @ tasks a possibility and also something that makes sense? I've never made changes to a low-level library package, let me know if you'd be open to a PR still..and of course, pointers are appreciated.

[connecteev]

Looked into it again, seems a bit more complex than my current skill level..

[driesvints]

I believe everything is possible

I'm sorry but I really don't think it is. You're working with CLI commands here, not PHP code. The blade control structures only allow you to organise the scripts. Maybe we can find a way to re-use parts.

I don't have the time to look into this at the moment so feel free to send in a PR if you have time.

[connecteev]

@driesvints I guess I'll have to stick with code duplication for now..not ideal but also not the end of the world.

[driesvints]

@connecteev I've tried to deep-dive into this but atm I really don't see a use case for this. If you could give me more info and especially some very concrete examples on what it is that you're trying to do then I'd be happy to look into this further.

Feel free to reply.

[connecteev]

@driesvints the use-case is basically keeping the code DRY so that I am not replicating a ton of the same code across stories and tasks in my Envoy script. Right now, I have no choice but to do that.

[connecteev]

That's what I mean by 'making it more manageable' or modular. More details in the description and #142. Let me know if anything is unclear about the use-case.