Cannot use @if within @finished about envoy

[driesvints]

Please fill out the issue template when posting issues.

[AdrienPoupa]

Done @driesvints let me know if I can be of any help

[driesvints]

@AdrienPoupa you should be able to write plain PHP there. Because it's a closure, short template tags won't work.

@finished
    if ($env != 'local') {
        @slack($slack, '#myChannel', "Deployment on {$env}: {$release} complete")
    }

    echo "Envoy deployment complete.\r\n";
@endfinished

[AdrienPoupa]

Good call, that works, thanks!

However, is it really necessary to make it a closure rather than a normal function?

[driesvints]

@AdrienPoupa I'm not super familiar with the internals of Envoy so I believe there probably is a reason for it yeah.