createAsCustomerIfNotExists about cashier-paddle

[driesvints]

Thanks @haszzam. Would maybe not filtering on status be the solution here to fetch all customers?

[haszzam]

Hi @driesvints

I checked the other discussion and it's the same issue I'm having here.

In your reply here #218 (comment)
You're assuming the customer already exists in the database, and if it does, then ya the createAsCustomer() checks to see if the billable model has a customer attached to it in the daatabse and if so it simply returns this customer instance.

The issue arise when you delete the customer from the database and leave the billable and then try to run createAsCustomer() again on the same billable instance.

The best way to understand this issue is to reproduce it locally on your end with the following steps:

1. Install a fresh laravel app
2. Install and configure Cashier (Paddle)
3. Run the migration
4. Add the following code to DatabaseSeeder.php file

public function run(): void
{
    $user = \App\Models\User::factory()->create([
        'name'              =>  'John Doe',
        'email'             =>  '[email protected]',
        'password'          =>  bcrypt('password'),
        'email_verified_at' =>  now(),
    ]);

    $user->createAsCustomer();
}

5. Run php artisan db:seed to create the demo user above
6. Run php artisan migrate:fresh to clear the database
7. Run php artisan db:seed to re-create the user again

The last command should fail, because the a customer with this email [email protected] already exists inside paddle.

So the whole point of this method createAsCustomerIfNotExists() is to prevent this failure by checking first if a customer with the same email exists inside paddle before attempting to create a new one.

Again, It's unlikely anyone gonna have this issue in a production environment, It's mostly gonna happen in development where you clear the database for whatever reason.

So This method would only make development a little easier, I don't know if it would make sense to add it to the library but I don't think it would hurt anyway to have available as an option.

[driesvints]

Thanks @haszzam. Paddle has fixed the filter issue. I've sent in a fix for this now here: #220

Please note that this still will only re-add the customer record. Any previous subscription and transaction records aren't re-added.

[haszzam]

Hi @driesvints.
Ya I understand it will only create an empty customer instance.

Thanks!