Coder Social home page Coder Social logo

Comments (1)

lapo-luchini avatar lapo-luchini commented on July 19, 2024

The number of bits you mention in Stream.prototype.parseInteger is meant as an approximation of the number size from a logical point of view, regarding the abstract number not its representation, thus
02050102030405 decodes a (33 bit) 4328719365,
02051102030405 decodes a (37 bit) 4328719365,
02057102030405 decodes a (39 bit) 485365056517,
0206008102030405 decodes a (40 bit) 554084533253.

On the other hand the number reported for negative values do not conform to the "logical number size" criteria, but rather "first 1 in the binary representation":
0206008102030405 decodes a (40 bit) 554084533253 (and logically should be 40),
02058102030405 decodes a (39 bit) -545427094523.

I don't think the solution is to add 1 to the length as 0x123 would be a 10 bit long number, which doesn't mean much to me intuitively, but rather fixing the negative number length to adhere to the same "logical value" principle.

What do you think of that?

PS: sorry about the long delay.

from asn1js.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.