constructor and componentDidMount is not called multiple times about react-keeper

[reneeichhorn]

Found out that this can be solved by adding the key prop to the Route component.
props.key = this.state.selfPathname before React.createElement(...)
There is no way to pass a unique key depending on the route currently (from the outside)

[lanistor]

@reneeichhorn
If there is a 'cache' property on your Route component? If so, the Detail page will be cached instead of unmounted when url is not matching.

[reneeichhorn]

It has one, I'm just using the example given in the repository
@vifird

[reneeichhorn]

The main issue is that without the key prop react won't understand what is a new component and what not. Therefore it will just think every route is just the same component. Even when going into a new route.

[lanistor]

Yeah, key property is used as ID of a component.
@reneeichhorn

[reneeichhorn]

I will give you an example:
Imagine a /product/:id route that uses the Product component. The product component uses componentDidMount to recieve data from the server. (as suggested by react best practices)

Now I navigate to /product/123. Product component is mounted, data for product with id 123 is fetched. Product component get rendered again after retrieving data.
Next I navigate to /product/456. Here is where the issue starts (the following problem appear WITH cache and also WITHOUT cache). The Product component is just rerendered with different props. componentDidMount is not executed again and therefore no new data is retrieved. Product will still display data for the 123 product because new data was not fetched.

With or without caching this should not happen. Without a proper key prop on the Route for React it will look like the same component just with different props, therefore only mounted once. This completely breaks React. And forces us to write workarounds.

[lanistor]

@reneeichhorn
Yeah, thanks for your issue. We are repairing this problem.

[lanistor]

Good one: next version 3

[koupeng]

也遇到了同样的问题，什么时候发布新版本啊？？？？？