Comments (7)
I see the point here and I am fine with the change.
Still want to say that my current pipelines (in pet projects) do depend somehow on that (which I only trigger via weekly builds as I do not have renovate up and running - yet).
So whatever change we make here should ofc reflect the needs of the laminas ecosystem but we should keep in mind where this all comes from and who is using this - since we published it as a publicly available action, we should kinda try to stick with decisions we made before - even tho they start being inconvenient at some point. If we start building a CI pipeline around renovate, we should properly note this in the documentation and create proper documentation on how to have a proper build pipeline along with renovate + the laminas CI stuff.
from laminas-ci-matrix-action.
I'll implement this (it's mostly code removal), and will patch the docs accordingly.
/cc @lcobucci IMO this is the last 2.0.0
change, then we can try out 2.0.x
on some repos, and finally release :)
from laminas-ci-matrix-action.
Yeah makes sense. With the lock file constantly updated, that now makes the latest tests redundant. +1 from me.
from laminas-ci-matrix-action.
I was going to say "hell no", but then read the bit about updating composer.lock
nightly, and it all makes sense.
from laminas-ci-matrix-action.
The point of latest is to notice those upstream breakages. And point of lock file is to quickly detect when those breakages are not something introduced by tested changes. With lock file maintenance in place the lock file covers both points so it make sense to remove latest. BUT lock file is only usable for the php version it was generated on. So latest would need to stay on any other php versions.
from laminas-ci-matrix-action.
The problem with latest
as it is configured right now is that it conflicts with completely unrelated CI pipelines. Contributors would get red builds for changes they had nothing to do with, and the same would apply to Renovate overnight updates.
So latest would need to stay on any other php versions.
Kinda agree that we need to somehow probe newer PHP versions with newer dependencies, and that we cannot run locked
against newer PHP dependencies either (simply won't run, sometimes).
Perhaps sticking with lowest
only (for newer PHP versions) is a safe-ish solution here, for now
from laminas-ci-matrix-action.
When I read this correct, most issues were runtime deprecations? Pretty sure that we explicitly want these - I was like "hell disable phpunit deprecation exceptions" in the past
Might still be a way to go. I was working on testing if we can have Jobs which may fail. Could still be something to be added to the matrix as a dedicated Job tho. Having deprecation warnings in phpunit confuse a lot but I see why we might want them - its just not a good place to trigger contributors attention because of that.
from laminas-ci-matrix-action.
Related Issues (20)
- Documentation: Add list of supported tools and how to ensure the checks are being properly generated
- Dependency Dashboard
- Verify `composer.json` constraint changes
- Implement dependency injection HOT 2
- `ext-pdo_sqlite` is not really installable HOT 12
- Consider composer validation commands HOT 4
- support for the config.bin-dir options in composer.json HOT 2
- Initial clone not working for private repositories HOT 5
- Add in `composer-require-checker` as a globally installed tool HOT 5
- Run psalm against highest PHP version? HOT 3
- Bump `package.json` to use `node:^19` HOT 1
- Stable PHP version should be changed to PHP 8.0 HOT 1
- GHA `set-output` is deprecated
- Implement a mechanism to shrink the `vimeo/psalm` baseline, when possible HOT 1
- Optimize `diff` within CI pipeline output for better readability in case of failing tests
- Allow `php` and `dependency` in `exclude` along with `name` reflecting the tools/checks name
- Enable code checks or linters when files from tools are changed (i.e. run all PHPUnit checks when `phpunit.xml.dist` is the only file within the diff)
- Generate `.laminas-ci.schema.json` from typescript interfaces rather than maintaining it manually
- More integrated integration testing
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from laminas-ci-matrix-action.