Comments (8)
@tve Let me think over it, I never thought this way ;)
from echo.
Cool, thanks for fixing!
You still have a problem with a trailing slash:
$ curl http://localhost:4444/acct/123/hello/
2015/05/04 21:44:20 http: panic serving [::1]:38441: runtime error: index out of range
goroutine 6 [running]:
net/http.func·011()
/big/usr-local/go/src/net/http/server.go:1130 +0xbb
github.com/labstack/echo.(*router).Find(0xc20800a750, 0xc20801e4e0, 0x3, 0xc20801e4e4, 0x10, 0xc208040550, 0x0, 0x0)
/home/src/github.com/labstack/echo/router.go:256 +0x407
github.com/labstack/echo.(*Echo).ServeHTTP(0xc208066000, 0x7f5e901a70d0, 0xc2080443c0, 0xc208032820)
/home/src/github.com/labstack/echo/echo.go:296 +0xd0
from echo.
Can you ack this issue or do I need to fork & fix myself? Thanks!
from echo.
I tried to fix it but it opened a can of worms. I am gonna give it a shot over the weekend, just hang on.
from echo.
from echo.
from echo.
Potentially a similar issue, I'm seeing group middleware with a wildcard group.Get match return the wrong url segment in the param value.
// instead of getting "labstack" from c.Param("thing"), I get "rules"
GET /v1/labstack/rules
func main() {
e = echo.New()
g := e.Group("/v1/:thing")
g.Use(ThingMiddleware)
g.Get("/*", Handle)
e.Run(":1234")
}
func ThingMiddleware() echo.HandlerFunc {
return func(c *echo.Context) error {
log.Println(c.Param("thing"))
return nil
}
}
func Handle(c *echo.Context) error {
return c.String(200, c.Param("thing"))
}
from echo.
@laicosly Looks like a bug when used with wildcard, it's the same even without using a group e.g. e.Get("/v1/:thing/*, Handle)
. Can you create a separate issue?
from echo.
Related Issues (20)
- Remove default charset from 'application/json' Content-Type header
- echo v4 websocket client closed, program exited HOT 3
- router not setting ContextKeyHeaderAllow for group, causing cors preflight to not work HOT 6
- Static file has wrong body returned when using a custom HTTP Error Handler and complex paths HOT 2
- QueryParams seem to override formValues HOT 3
- DefaultHTTPErrorHandler does not log HOT 3
- Support Casbin Authorization Middleware HOT 1
- Echo response object calls flush on unflushable objects HOT 7
- Feature request: support Yaml responses transparently. HOT 1
- static middleware: path ist unescaped twice for file names, leading to not downloadable content
- CSRF middleware form lookup consumes all the request body HOT 1
- Question: How can I serve content from static HTML files using URLs that have no '.html' extension HOT 5
- Omitempty in form HOT 1
- Return error if reverse() does not find a match HOT 9
- How to read a path param with echo that can contain slashes? HOT 3
- Unclear behaviour of `*` in routes HOT 7
- middleware.CORSConfig can not be configured per path HOT 2
- Is there any plan to facilitate responses in the Protobuf data format? HOT 2
- When `c.bind()` fails with a type error on POST'd form data the `inputfieldname` is not available HOT 3
- Using static middleware, does not raise handler at '/*' path HOT 13
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from echo.