PingPongDelayNode issue about labsound

[Q-Qian]

Does it work as you expect with that change? Happy to update the code if so.

yes! An error will be reported when running before changing, I will change it and push

[meshula]

I think that the gain was supposed to auto configure to the right number of inputs dynamically.

The implementation should match this

https://github.com/web-audio-components/delay/blob/master/index.js

We should go through that implementation, and the LabSound implementation line by line to make sure they match.

[Q-Qian]

I think that the gain was supposed to auto configure to the right number of inputs dynamically.

The implementation should match this

https://github.com/web-audio-components/delay/blob/master/index.js

We should go through that implementation, and the LabSound implementation line by line to make sure they match.

I think the destIdx and srcIdx were reversed, line 72 ac.connect(splitterGain, splitter, 1, 0) should be ac.connect(splitterGain, splitter, 0, 1); line ac.connect(merger, rightDelay, 0, 1) should be ac.connect(merger, rightDelay, 1, 0);

[meshula]

Does it work as you expect with that change? Happy to update the code if so.