Comments (4)
You shouldn't convert queries into other queries inside Kysely. Kysely is a query builder, and if you build a delete query, it should build a delete query.
As @igalklebanov said, the KyselyProps
constructor and RuntimeDriver
are part of the internal API and shouldn't be used/exposed.
We should remove this check though as it's too prohibitive.
from kysely.
We should remove this check though as it's too prohibitive.
Maybe make this configurable and keep it strict by default? As a way to defend from "bad faith plugins"..
from kysely.
Hey 👋
Why are you trying to instantiate Kysely
with KyselyProps
? These are internals.
Did you follow kysely.dev/docs/getting-started ?
@koskimas maybe we should alter the output types post-build to remove KyselyProps
from being an option in userland?
from kysely.
I wrote an Audit plugin that audits row data for all create/update/delete queries, but this block of code restricts changing node.kind
in transformQuery()
.
https://github.com/kysely-org/kysely/blob/master/src/query-executor/query-executor-base.ts#L37
I am currently doing this as there isn't an async callback called before a query is executed in order to track deletes. I overrode this logic by instantiating Kysely
with KyselyProps
I found in another github issue and noticed that RuntimeDriver
dependency isn't exported.
I needed to transform a delete query into a select, so that I can audit data that is being deleted before the delete query is ran, in a generic way (applied to all deletes ran).
The node.kind
check makes sense, but I have to override it for this functionality, unless I put a PR up to add a plugin callback that is triggered before a query is executed with the current database connection. Then I would not need to export this RuntimeDriver
that I noticed was missing.
Thoughts?
from kysely.
Related Issues (20)
- Multi-statement queries causes wrong result interpretation HOT 2
- Kysely mssql dialect support for bun improved HOT 1
- SELECT ARRAY function? HOT 3
- Implement `WITH` for create index HOT 1
- MariaDB (v10) using jsonObjectFrom and jsonArrayFrom HOT 2
- Select columns as NULL or as placeholder HOT 1
- Support table names in UpdateQueryBuilder.returningAll
- orderBy gives an error when a space separated string of sortBy and sortOrder is passed in eg- orderBy('sortBy sortOrder') HOT 2
- Memory issue when inserting lots of records to postgres HOT 1
- Pronunciation help is wrong HOT 3
- QueryCompilerError: Could not serialize value causes Kysely instance to fail later HOT 2
- Feature request: Feedback possibility during Migration HOT 1
- Is there a way to deduplicate parameters in template strings? HOT 1
- Postgres Introspection getTables() misses partition tables
- CamelCasePlugin messes up complex type mappings with setTypeParser HOT 2
- How to handle "empty" column selections? HOT 1
- The type of `eb` in `selectFrom(eb => ...)` is wrong
- RLS via Plugin? HOT 5
- getting started documentation errors with MssqlDialect
- db.schema returns undefined HOT 4
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from kysely.