Coder Social home page Coder Social logo

Comments (4)

koskimas avatar koskimas commented on September 26, 2024 2

I fixed the getting started guide.

from kysely.

igalklebanov avatar igalklebanov commented on September 26, 2024

Hey 👋

This is a documentation issue - PR's welcome.

  1. findPersonById should accept bigint or even number | bigint.
  2. Since we're in MySQL context - insertId is not undefined, you can add a non-null assertion as follows: return await findPersonById(insertId!)

from kysely.

linas-ipxo avatar linas-ipxo commented on September 26, 2024

Okay, but then person is defined as

export interface PersonTable {
  // Columns that are generated by the database should be marked
  // using the `Generated` type. This way they are automatically
  // made optional in inserts and updates.
  id: Generated<number>
  ...

and the Person interface doesn't accept bigint in other parts of the examples. I can change everything to bigint, but shouldn't the executeTakeFirstOrThrow() function return insertId typed based on the interface (number)? and not bigint?

from kysely.

koskimas avatar koskimas commented on September 26, 2024

We don't know which property is the auto incrementing primary key. All Kysely sees is the table interface and there's no indication of the primary key. Some tables don't even have it or they have a composite primary key.

Bigint is used because it can hold any integer value, unlike number.

You can easily cast the type using Number(insertId!)

from kysely.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.