The oform from kylerush

Checkbox returning checkbox value rather than checkbox.checked property

If a checkbox in input has attribute checked="checked" oform submit data will have the checkbox value whether it is checked or not

Support for custom error messages

Needs to support custom error messages. For example, consider a password field. The password field may have certain requirements. If no value is entered into the password field "Required" may be a good error message. But if a value is entered and the value does not conform to the requirements, "Not a valid password" might be a better error message.

Expose form data in success function

Would be nice to expose the form data that has been collected from the inputs in the success function if the form doesn't actually post.

success event doesn't work properly in 3.0.0

doesn't execute for form POSTs

move qunit from dependencies to devdependencies

validate non-required fields

there should be an option to validate fields that don't have a required option. if the field does not have a blank string then the value should be validated even if it doesn't have the required attribute.

this should be done by adding a data attribute to the input like so:

<input type="email" name="email" data-validate>

hidden inputs not being sent in XHR

switch everything to use element.classList and get rid of that awful adjustClass function

adjustClasses function selector isn't scoped to selected form

Add support for radio buttons

To reproduce:
Pull this branch

Go to http://localhost:9000/dist/sxsw/

Press submit, observe JS error in console

Comment out all of radio-option-container in website-guts/templates/layouts/events_form.hbs
Observe no error.

add validaton option

need to add an option that allows you so specify when the validation option executes.

should look like this:

new Oform({
  selector: '#form',
  validateon: 'keyup'
});

options should be:

'keyup'
'focusin'
'focusout'

validationError event not firing

put a break point in the validation error function and it's not firing

Create processing state

The production site changes the background of inputs to light grey while processing. I tried implementing this with the before and load events but it gets complicated because before will run even if there is a validation error, and if there is a validation error load will not fire.

Pass object for named arguments to callback functions

instead of passing a list of arguments to the callback, should pass and object like:

{
    jqXHR: ,
    callback: ,
}

makes checking for successful submission easier by doing:

if(typeof args.jqXHR === 'object')

responseJSON property is undefined on jqXHR object

The jqXHR object that gets passed to the callback functions is not correct. The responesJSON is added to the object, but not in the responseJSON property as the documentation states.

Screenshot: http://d.pr/i/uFrJ

Success listener does not received structure object of form data

Checkbox error message not showing

Error class is being applied to the checkbox input but not to it's associated error message sibling

errorHiddenClass not being removed upon failed validation

error-show class is being applied but error-hidden class is not being removed

Create a success and statusError handler

in the onreadystatechange potentially create events for success and statusError as the current 'error' event doesn't seem to fire on a failing status

xhr.onreadystatechange=function(){
       if (xhr.readyState==4 && xhr.status==200){
       }
    }
}

http://stackoverflow.com/questions/10876123/how-to-find-out-if-xmlhttprequest-send-worked

Custom validation passes the element as a parameter not the value

The callback for customValidation has the element as a parameter not the input value. Either change the docs or the functionality

    password: function(val){
      if(val.length >= 7){
        return true;
      } else {
        return false;
      }
    }
  }

Email Validation

It doesn't look like the email validation is working properly

Remove jQuery dependency

add support for no method attribute on form tag

if no method attribute is on the form tag selector Oform should not do a POST request and instead just run a success function if the form validated correctly. the success function should still run though if there is a method attribute after the response is received.

form should not submit if before callback does not return true

currently the form submits even if the before function does not return true.

body.error class

in the rewrite this feature got lost. upon each form submit oform should adjust the body class. if there are validation errors, oform should add an error class to the <body> tag. if there are no errors it should remove the class.

should be used like this:

new Oform({
  selector: '#form',
  bodyErrorClass: 'error'
});

default:

new Oform({
  selector: '#form',
  bodyErrorClass: 'oform-error'
});

to disable this feature:

new Oform({
  selector: '#form',
  bodyErrorClass: null
});

if( instance.options.validate[type] ){

it just checks to see if the function exists. it needs to actually execute the function and pass an argument.

kylerush / oform Goto Github PK

oform's People

Contributors

Stargazers

Watchers

Forkers

oform's Issues

Recommend Projects

Recommend Topics

Recommend Org