Coder Social home page Coder Social logo

Comments (7)

LukeXF avatar LukeXF commented on June 13, 2024 2

Downgrading from 1.5.3 to 1.5.2 fixes this issue.

from apicache.

kwhitley avatar kwhitley commented on June 13, 2024 2

Fixed as of now @ 1.6.2

Thanks very much for everyone's patience!

from apicache.

imnotjames avatar imnotjames commented on June 13, 2024

Yeah - does look like in the 1.5.3 release that restriction was added but unclear the reasoning. It doesn't seem related to the redis fix included in the release?

from apicache.

imnotjames avatar imnotjames commented on June 13, 2024

#212 (comment) Looks like this is why?

So we continue to be plagued by issues trying to resolve tests using restify with Node v13+ (with or without gzip, I'm finding).

I'm proposing we finish updating the repo with the changes above (dropping old Node support), and temporarily drop official support for restify (specifically when used with node 13+). I'd add in a check to allow Travis to run the tests for restify+gzip with Node 12 and under. Either way, this will be part of the v2 release that will go into cruise control while we make a decent/all-new API for v3.

from apicache.

kwhitley avatar kwhitley commented on June 13, 2024

@imnotjames is correct... under Node 14, the restify and redis tests break down hard:
image
image
image

from apicache.

kwhitley avatar kwhitley commented on June 13, 2024

As I don't use restify or redis in my projects, I'd hoped someone else would spearhead the fixes there as I have no easy way to test these beyond the test suite.

In hindsight, and should apicache realistically get to a proper v2, it'll drop baked-in support for either, instead allowing any store mechanism with a standard interface to be plugged into apicache - making it backend agnostic. This would allow others to author/maintain the plugins, and apicache to simply focus on firing the appropriate cache calls and handling the response/headers side of things.

from apicache.

kwhitley avatar kwhitley commented on June 13, 2024

The next problem is that I have moved on past express in the last year and will likely focus on serverless (CloudFlare Workers) for the near future, and thus library focus will be on improved tooling in that workflow (Example: https://www.npmjs.com/package/itty-router). If someone would like to collaborate on a v2 of apicache, I'd be happy to discuss and pass the torch if the vision aligns! 👍

from apicache.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.