Coder Social home page Coder Social logo

Comments (7)

richrout avatar richrout commented on May 12, 2024 1

This is reproducible if you just add the following styles to the .smooth-dnd-container on the demo page.

    max-height: 400px;
    overflow-y: auto;

image

Try dragging a card towards the left/right side where it should start scrolling, instead it does nothing.

image

from smooth-dnd.

HoaDevDn avatar HoaDevDn commented on May 12, 2024 1

yep
i got the same issue =((
Can't scroll if we set max-height for the column
could you hot fix?
@johanneswilm @richrout @klaasman @kutlugsahin

from smooth-dnd.

gregoryforel avatar gregoryforel commented on May 12, 2024

Hello @johanneswilm , @richrout , @klaasman @kutlugsahin ! A gentle bump, in case any of you has some time to look into this issue. Many thanks in advance in any case, and thanks for the library!

from smooth-dnd.

richrout avatar richrout commented on May 12, 2024

I have a pull request that I tested and works for the "Trello scenario"

No one has looked at the PR though: #55

from smooth-dnd.

gregoryforel avatar gregoryforel commented on May 12, 2024

Thanks @richrout ! 3 questions if I may:

  • "puts the onus on the consumer to set up their UI in a way that overlaps are easy to navigate": do you actually have anything in particular to do other than properly setting up your CSS correctly and setting disableScrollOverlapDetection to true?
  • Any idea how the guys who created react-trello did it? They do use react-smooth-dnd, and their lib works.
  • Do you have a working repo with your solution that demos your work that I could check?

from smooth-dnd.

richrout avatar richrout commented on May 12, 2024

For sure.

  • yeah that's all it means.
  • they use a fork now. I don't think this was a problem until the "overlap scroll detection" was added.
  • nothing right now. I had quickly modified it on the demo page to show it in the screenshots above. Lemme know if you want me to create something, or even a separate demo page to show how to do it.

from smooth-dnd.

gregoryforel avatar gregoryforel commented on May 12, 2024

No need to demo. Thank you so much! It works like a charm. Maybe you can bump the guys ref your PR again? So many people have the same issue.

from smooth-dnd.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.