Comments (4)
Yup, I would guess that null-checking the textNode.value
prior to trying to call HtmlUnescape.convert()
on it would potentially resolve the issue.
https://github.com/Kumanu/contentful-rich-text-flutter/blob/master/lib/contentful_rich_text.dart
184 String nodeValue = HtmlUnescape().convert(textNode.value);
Happy to accept a PR that updates that, or I'll try to address it. In the meantime I'd recommend not including the entry link if possible.
from contentful-rich-text-flutter.
Disabling unsupported types is definitely planned, however I would still prefer if the parser wouldn't crash in case the configuration is off ;)
I'll create a PR with this check:
if (textNode.value == null) return TextSpan();
Would it be ok to also add the following block? That way links to entries would still be ignored, but at least the text would be output. Without it, the above would only output a blank line:
// for links to entries only process the child-nodes
if (node['nodeType'] == 'entry-hyperlink') {
return TextSpan(
children: node['content']
.map<TextSpan>((subNode) => _processInlineNode(subNode) as TextSpan)
.toList(),
);
}
from contentful-rich-text-flutter.
Yup, I like the idea of keeping the text
from contentful-rich-text-flutter.
resolved via #9
from contentful-rich-text-flutter.
Related Issues (13)
- Using tables HOT 3
- Support additional tags HOT 2
- Question about the style of the text HOT 1
- Click handler on hyperlink is not working HOT 3
- hyperlink not clickable HOT 2
- No support for Marks HOT 1
- Add Github Actions support for running tests
- support transfer to plain text HOT 1
- Support for tables HOT 6
- RenderMark and RenderNode are not working HOT 4
- Embedded Asset HOT 1
- Not sufficient space between paragraphs HOT 8
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from contentful-rich-text-flutter.