Bug with 'upload' action in control method about ngx-uploadx

[kukhariev]

more detailed:

if concurrency=2
third call to this action does not set the event.itemOptions

        if (this.concurrency - this.runningProcess() > 0) {
          upload.upload(event.itemOptions);
        } else if (upload.status === ('added' as UploadStatus)) {
          upload.status = 'queue' as UploadStatus;
        }

[wil92]

I think that should be the behavior, if there are currently 2 uploading files and you put a 3rt one, this should wait for start uploading and not start immediately, because the concurrency is 2 and should not be more than 2 uploading at the same time.

For start the pending copies, I subscribe to subj observable and after some uploading finish, and the autoplay is true, then start the pending uploadings

constructor() {
    this.subj.subscribe((uploadState: UploadState) => {
      if (
        uploadState.status === 'complete' ||
        uploadState.status === 'cancelled' ||
        uploadState.status === 'error'
      ) {
        this.autoUploadFiles();
      }
    });
  }

So, when one of the first two copies finish, then the 3th one start uploading

[kukhariev]

to see this bug, in the file selection dialog, select 3 files with the Ctrl key pressed.
third file requests will lose the 'Content-Disposition' header.

//  src/app/service-way/service-way.component.ts

        const cfg: UploadItem = {
          headers: {
            'Content-Disposition': `filename=${encodeURI(item.file.name)}`
          },
          metadata: {
            size: item.file.size,
            lastModified: item.file.lastModified
          }
        };
        this.uploadService.control({
          action: 'upload',
          itemOptions: cfg,
          uploadId: item.uploadId
        });

[wil92]

I tried to reproduce the bug but i couldn't. This is a picture of one of the times I tried.

Maybe is your browser, what you are using? (I'm using chrome)

[kukhariev]

Chome.
http://localhost:4200/service-way, http://localhost:4200/service-code-way
master branch, with concurrency fix 0f41f5e (#11)