Comments (6)
Can the release note generator detect rolled back changes?
On Fri, Jun 24, 2016 at 5:23 PM, David McMahon [email protected]
wrote:
There's no way to target different release note states for multiple
branches due to the fact that the release note state is based on the one
source PR, not the individual cherry-picks.For example, #27861 seems like a good release note for 1.3 but we don't
want it as a relnote for 1.2.5 (since it was rolled back).The fix probably entails checking the cherry-pick for a release note state
and letting it override the source PRs state and then updating the
cherry-pick doc to allow for that in these special circumstances. I can't
immediately think of any issues with that approach.It will mean more processing time and github polling to check labels for
both PRs for every merge pull.cc @eparis https://github.com/eparis @roberthbailey
https://github.com/roberthbailey—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
#17, or mute the thread
https://github.com/notifications/unsubscribe/AHuudn7OQU52I6BIsxqmXJkWhWbzcBQoks5qPHUNgaJpZM4I-OGe
.
from release.
@erictune No. I had considered adding that, but then our canonical method for exposing release notes is through labeling and that single interface provides more flexibility in deciding what should or should not be captured as a release note (rollback spanned releases, rollback itself was relevant for capturing the fact that a feature didn't make it in a release, etc). Adding more moving parts here might confuse things.
from release.
Issues go stale after 30d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale
.
Stale issues rot after an additional 30d of inactivity and eventually close.
Prevent issues from auto-closing with an /lifecycle frozen
comment.
If this issue is safe to close now please do so with /close
.
Send feedback to sig-testing, kubernetes/test-infra and/or @fejta
.
/lifecycle stale
from release.
/sig release
from release.
Stale issues rot after 30d of inactivity.
Mark the issue as fresh with /remove-lifecycle rotten
.
Rotten issues close after an additional 30d of inactivity.
If this issue is safe to close now please do so with /close
.
Send feedback to sig-testing, kubernetes/test-infra and/or @fejta
.
/lifecycle rotten
/remove-lifecycle stale
from release.
Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen
.
Mark the issue as fresh with /remove-lifecycle rotten
.
Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/close
from release.
Related Issues (20)
- new kubernetes el7 repo ? HOT 11
- Edited release notes will logically interfere with mapped values
- No worldwide location for legacy packages HOT 4
- Error install kubernates HOT 2
- Release Notes Collection Picks Up Incorrect Text HOT 7
- The repository 'https://pkgs.k8s.io kubernetes-xenial InRelease' is not signed HOT 5
- Dependency update - Golang 1.22.2/1.21.9 HOT 4
- Version 1.29.1 kubectl not found HOT 4
- Error while installing kubernetes "kubernetes-xenial Release' does not have a Release file." HOT 6
- Refactor `pkg/announce` package to adhere to the interfaces pattern HOT 2
- Cannot upgrade kubeadm to 1.30.0 via apt HOT 10
- Cannot find `kubernetes-cni` in repo HOT 7
- Error 403 from https://prod-cdn.packages.k8s.io/repositories/isv:/kubernetes:/core:/stable:/1.30/rpm/repodata/repomd.xml HOT 5
- Presubmit job `pull-release-cluster-up` fails consistently HOT 1
- CVE-2024-2961 in `registry.k8s.io/build-image/distroless-iptables:v0.5.3` HOT 6
- Dependency update - Golang 1.22.3/1.21.10 HOT 2
- Add a file to get the current latest version. HOT 2
- Upgrade from 1.21 to 1.24 HOT 2
- debian packages for v1.28.9 not available HOT 5
- Dependency update - Golang 1.22.4/1.21.11 HOT 9
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from release.