dont error out at end when there is no permission to push to the branch about release

[david-mcmahon]

Thanks for the report. What was the original command line?

[jessfraz]

anago release-1.4 --buildversion=v1.4.1-beta.0.63+90a2226c1bc505 --nomock

[david-mcmahon]

Try running without the --nomock flag to make sure you can get through a run.

I added you to the auth page for the branch to allow pushes.

I'll send a fix for this issue shortly that checks the correct auth.

[jessfraz]

ya I did and that worked

On Fri, Oct 7, 2016 at 3:43 PM, David McMahon [email protected]
wrote:

Try running without the --nomock flag to make sure you can get through a
run.

I added you to the auth page for the branch to allow pushes.

I'll send a fix for this issue shortly that checks the correct auth.

—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
#136 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/ABYNbArVxvCEvOSWPZL5xhY54iCASQr5ks5qxsslgaJpZM4KRhCi
.

[jessfraz]

Thanks!!!

On Fri, Oct 7, 2016 at 3:45 PM, Jessica Frazelle [email protected]
wrote:

ya I did and that worked

On Fri, Oct 7, 2016 at 3:43 PM, David McMahon [email protected]
wrote:

Try running without the --nomock flag to make sure you can get through a
run.

I added you to the auth page for the branch to allow pushes.

I'll send a fix for this issue shortly that checks the correct auth.

—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
#136 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/ABYNbArVxvCEvOSWPZL5xhY54iCASQr5ks5qxsslgaJpZM4KRhCi
.

[david-mcmahon]

@jessfraz you did what? Were you able to complete a non-mock run? You should also have hit the auth issue in mock mode (up until a few minutes ago when I added you to administrators for that branch).

[jessfraz]

I was able to complete a mock run because it used --dry-run, it all
looked good

On Fri, Oct 7, 2016 at 3:47 PM, David McMahon [email protected]
wrote:

@jessfraz https://github.com/jessfraz you did what? Were you able to
complete a non-mock run? You should also have hit the auth issue in mock
mode (up until a few minutes ago when I added you to administrators for
that branch).

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#136 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/ABYNbIPG3NMAJ8aHX-j2ySd8OBj23Pjqks5qxswOgaJpZM4KRhCi
.

[jessfraz]

Sorry I just meant it worked without the flag --nomock

[david-mcmahon]

Very troubling that --dry-run would behave differently when pushing. That means we have no way to validate auth/perms before we allow the release to happen. I'm going to remove you from the branch again. Can you send me the output of this?

$ git push --dry-run origin release-1.4

[jessfraz]

$ git push --dry-run origin release-1.4
To [email protected]:kubernetes/kubernetes.git
   6fb175e..4b5e85d  release-1.4 -> release-1.4

[fejta-bot]

Issues go stale after 30d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

Prevent issues from auto-closing with an /lifecycle frozen comment.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or @fejta.
/lifecycle stale

[david-mcmahon]

Addressing the specific issue of branch auth based on repo admin, that has been resolved.