Comments (4)
Gootcha, you rely on the label as an affinity selector within your own workflow, while my observation was oriented more towards kops' own functional integrity. Thanks for clarifying -
from kops.
Is this a bug?
Without too much understanding of the codebase design, I notice there's a fallback to "node" role type. If I am not off-track, this is more of an enhancement for a null check anti-pattern due to a hotspot in the codebase, so perhaps nothing to worry about.
from kops.
@teocns Not sure if I understand your comment but the issue is not related with the actual node type, that works just fine.
The issue is that the label (at node level) which identifies the KOPs instance group for each specific node is missing when using the kops create cluster
command - we can manually add it afterwards but I wouldn't expect to have to do that, specially because when you create a new instance group the nodeLabels
is automatically injected (as described in point 4), and also because this was "working" at some point before (as I have nodes from clusters created with older KOPs versions contain the label).
For our environments that was a breaking change (and we had to manually update+rollout the IGs) because we actively use things like kubernetes anti/affinity rules and prometheus metrics which rely in the value of the kops.k8s.io/instancegroup
node label.
The actual yaml/property that I would expect to be present for each IG created via kops create cluster
command is 👇
nodeLabels:
kops.k8s.io/instancegroup: <IG_NAME>
from kops.
The Kubernetes project currently lacks enough contributors to adequately respond to all issues.
This bot triages un-triaged issues according to the following rules:
- After 90d of inactivity,
lifecycle/stale
is applied - After 30d of inactivity since
lifecycle/stale
was applied,lifecycle/rotten
is applied - After 30d of inactivity since
lifecycle/rotten
was applied, the issue is closed
You can:
- Mark this issue as fresh with
/remove-lifecycle stale
- Close this issue with
/close
- Offer to help out with Issue Triage
Please send feedback to sig-contributor-experience at kubernetes/community.
/lifecycle stale
from kops.
Related Issues (20)
- How to factorize code between kops and cluster api? HOT 2
- How to use the power of reserved resources with ubuntu 22.04, containerd , kops1.27 and aws!
- cluster-autoscaler: Wrong configuration for priority expander
- EOF Error from AWS api while validating cluster which was in running state HOT 18
- Bump nvidia driver for CUDA 12.1 support HOT 4
- updating kops DNS records
- Oracle OCI Deploy Support HOT 3
- [CILIUM] CiliumNetworkingSpec should be able to set all configs like API Rate Limit gathering lots of TooManyRequests HOT 2
- Kops api server pod is restarting and showing x509: certificate has expired or is not yet valid". Reconnecting... W0515 13:17:42.270070
- ASG Warmpool instances join before Lifecycle hook is in effect HOT 9
- Poorly documented: nonMasqueradeCIDR vs podCIDR vs serviceClusterIPRange
- Cluster validation cannot complete if metrics-server addon is enabled and there are less than 2 non-master nodes
- "kops version --server" should assume current context by default HOT 4
- Mistake in validation of Node Termination Handler
- Calico in eBPF mode has bug and should be upgraded to 3.27.3 for Kops 1.28.5 and below HOT 3
- Can't modify aws-node daemonset to pull different images HOT 3
- Add ProxMox Support
- GCE cluster deletion fails when unable to list InstanceGroupManagers
- Node-local-dns doesn't work with cilium CNI on kops 1.29.0
- Hetzner: error running task "ServerGroup/bastions": Field is required: UserData
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from kops.