Coder Social home page Coder Social logo

Comments (6)

thockin avatar thockin commented on May 16, 2024

from k8s.io.

fejta-bot avatar fejta-bot commented on May 16, 2024

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

Prevent issues from auto-closing with an /lifecycle frozen comment.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or @fejta.
/lifecycle stale

from k8s.io.

thockin avatar thockin commented on May 16, 2024

I was inspired to try this again. I think I know how to make it produce the text I want, but my phony canary test is not working.

$ go get -d -insecure go.clustermaster.net/kubectl
Skippy Security Tip: It seems that you are using the -insecure flag. This flag disables integrity and authenticity checking, which means someone could tamper with your download.
Suggestion: Use go get without the flag: -insecure
More info: http://go/roole/go_cmd.md
Do you still want to execute this command? [y/n]y
package go.clustermaster.net/kubectl: unrecognized import path "go.clustermaster.net/kubectl" (parse https://go.clustermaster.net/kubectl?go-get=1: no go-import meta tags (meta tag k8s.io/kubectl did not match import path go.clustermaster.net/kubectl))

vs

$ curl -i http://go.clustermaster.net/kubectl?go-get=1
HTTP/1.1 200 OK
Server: nginx/1.10.3
Date: Tue, 02 Jan 2018 21:51:17 GMT
Content-Type: text/html
Content-Length: 450
Connection: keep-alive


            <html><head>
                  <meta name="go-import"
                        content="k8s.io/kubectl git https://github.com/kubernetes/kubectl">
                  <meta name="go-source"
                        content="k8s.io/kubectl https://github.com/kubernetes/kubectl https://github.com/kubernetes/kubectl/tree/master{/dir} https://github.com/kubernetes/kubectl/blob/master{/dir}/{file}#L{line}">
            </head></html>

Clearly the go-import meta tag IS there...

The config block in question is:

      location ~* ^/([^/]*)(/.*)?$ {
        default_type text/html;
        if ($arg_go-get = "1") {
            return 200 '
                <html><head>
                      <meta name="go-import"
                            content="k8s.io/$1 git https://github.com/kubernetes/$1">
                      <meta name="go-source"
                            content="k8s.io/$1 https://github.com/kubernetes/$1 https://github.com/kubernetes/$1/tree/master{/dir} https://github.com/kubernetes/$1/blob/master{/dir}/{file}#L{line}">
                </head></html>
            ';
        }
        return 301 https://$host$request_uri;
      }   

from k8s.io.

thockin avatar thockin commented on May 16, 2024

Aha, I have it. See PR.

from k8s.io.

fejta-bot avatar fejta-bot commented on May 16, 2024

Stale issues rot after 30d of inactivity.
Mark the issue as fresh with /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle rotten
/remove-lifecycle stale

from k8s.io.

fejta-bot avatar fejta-bot commented on May 16, 2024

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen.
Mark the issue as fresh with /remove-lifecycle rotten.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/close

from k8s.io.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.