Coder Social home page Coder Social logo

Comments (3)

mkumatag avatar mkumatag commented on August 29, 2024 1

The create volume operation is considered to be successful only when the state value of the volumeDetails is available. The state represents the attachment state of the volume. The state in-use represents that the volume is already attached.

We don't need to add a new method to wait for the volume to be available. We can use the existing method WaitForAttachmentState in here: WaitForAttachmentState.

nice, I almost forgot about this function, lets reuse whatever we have.

Couple of comments:

  • WaitForAttachmentState name doesn't make sense to me, we can make it more generic like WaitForVolumeState to wait for any state
  • There is dump statement in the WaitForAttachmentState, need to be removed.

from ibm-powervs-block-csi-driver.

Madhan-SWE avatar Madhan-SWE commented on August 29, 2024

/assign

from ibm-powervs-block-csi-driver.

Madhan-SWE avatar Madhan-SWE commented on August 29, 2024

The create volume operation is considered to be successful only when the state value of the volumeDetails is available.
The state represents the attachment state of the volume. The state in-use represents that the volume is already attached.

We don't need to add a new method to wait for the volume to be available. We can use the existing method WaitForAttachmentState in here: WaitForAttachmentState.

from ibm-powervs-block-csi-driver.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.