Comments (13)
Sounds great @SD-13. It might make more sense to break some of these down into several smaller PRs. We can talk about different aspects as you work on them and figure out what makes sense. Reach out on slack or via this message if you have any issues.
from hydrophone.
This issue will likely involve a bit of a rethinking on how we're handling the command line and default behavior. Some initial thoughts:
./hydrophone
should:- run run the conformance test suite like with
--conformance
. - pending #94, should run the conformance image on the same version as the test cluster
- should get the logs and output them to the output-dir
- should cleanup all of the resources
- run run the conformance test suite like with
./hydrophone --focus
should remain as is and override setting cfg.Focus. Some work required https://github.com/kubernetes-sigs/hydrophone/blob/main/pkg/common/args.go#L139C1-L141 and https://github.com/kubernetes-sigs/hydrophone/blob/main/pkg/common/args.go#L139C1-L141../hydrophone --cleanup
should remain the same- Adding in a
get-logs
orfetch-logs
option may require some significant rework and design since they're streamed out of the sidecar busybox container. To decouple this we'll need some kind of more persistent storage solution that can be ad-hoc accessed after a run of the conformance image completes.
Other notes:
- This may be a good time to introduce cobra or some other CLI wrapper to better organize
main.go
from hydrophone.
/assign
I would like to try
from hydrophone.
This may be a good time to introduce cobra or some other CLI wrapper to better organize
main.go
+1 to this.
from hydrophone.
Hey @SD-13! Wanted to ask you that will you be interested in collaborating on this issue. Like while you are looking into one of the subparts, maybe I can look into the other one?
from hydrophone.
@SD-13 please collabroate with @rakshitgondwal and @rjsadow on slack and may be pick up smaller issues / pr(s) as this is a larger piece of work that needs to be broken down.
from hydrophone.
Hi @rjsadow @rakshitgondwal from what I see as scope of the issue still need to figure out "get-logs or fetch-logs" part . is anyone working on it? and whats the plan? I am interested to contribute
from hydrophone.
Hi @rjsadow @rakshitgondwal from what I see as scope of the issue still need to figure out "get-logs or fetch-logs" part . is anyone working on it? and whats the plan? I am interested to contribute
Hey @reetasingh, afaik no one is working on that part right now but I am not so sure if we are planning to implement this right now. Maybe Ricky can tell more about this.
from hydrophone.
Hey 👋
I can also take some part of this issue and work on it with all
from hydrophone.
The Kubernetes project currently lacks enough contributors to adequately respond to all issues.
This bot triages un-triaged issues according to the following rules:
- After 90d of inactivity,
lifecycle/stale
is applied - After 30d of inactivity since
lifecycle/stale
was applied,lifecycle/rotten
is applied - After 30d of inactivity since
lifecycle/rotten
was applied, the issue is closed
You can:
- Mark this issue as fresh with
/remove-lifecycle stale
- Close this issue with
/close
- Offer to help out with Issue Triage
Please send feedback to sig-contributor-experience at kubernetes/community.
/lifecycle stale
from hydrophone.
The Kubernetes project currently lacks enough active contributors to adequately respond to all issues.
This bot triages un-triaged issues according to the following rules:
- After 90d of inactivity,
lifecycle/stale
is applied - After 30d of inactivity since
lifecycle/stale
was applied,lifecycle/rotten
is applied - After 30d of inactivity since
lifecycle/rotten
was applied, the issue is closed
You can:
- Mark this issue as fresh with
/remove-lifecycle rotten
- Close this issue with
/close
- Offer to help out with Issue Triage
Please send feedback to sig-contributor-experience at kubernetes/community.
/lifecycle rotten
from hydrophone.
The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.
This bot triages issues according to the following rules:
- After 90d of inactivity,
lifecycle/stale
is applied - After 30d of inactivity since
lifecycle/stale
was applied,lifecycle/rotten
is applied - After 30d of inactivity since
lifecycle/rotten
was applied, the issue is closed
You can:
- Reopen this issue with
/reopen
- Mark this issue as fresh with
/remove-lifecycle rotten
- Offer to help out with Issue Triage
Please send feedback to sig-contributor-experience at kubernetes/community.
/close not-planned
from hydrophone.
@k8s-triage-robot: Closing this issue, marking it as "Not Planned".
In response to this:
The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.
This bot triages issues according to the following rules:
- After 90d of inactivity,
lifecycle/stale
is applied- After 30d of inactivity since
lifecycle/stale
was applied,lifecycle/rotten
is applied- After 30d of inactivity since
lifecycle/rotten
was applied, the issue is closedYou can:
- Reopen this issue with
/reopen
- Mark this issue as fresh with
/remove-lifecycle rotten
- Offer to help out with Issue Triage
Please send feedback to sig-contributor-experience at kubernetes/community.
/close not-planned
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.
from hydrophone.
Related Issues (20)
- run-e2e script CHECK_DURATION: unbound variable HOT 7
- Simplify Testing setup with Makefile HOT 4
- `#hydrophone` should be added to the README HOT 9
- Remove `cfg` and `config` from `PrintListImages()` HOT 3
- Fix different timezones in logs HOT 13
- Show some progress info for the tests HOT 3
- Redundant error check in client.PrintE2ELogs() function HOT 4
- Add a brew repo HOT 12
- hydrophone --cleanup is broken HOT 3
- Broken links in README HOT 5
- multiple typo and grammatical mistake in air-gapped.md HOT 2
- Improve logging for resource creation HOT 6
- `--parallel` flag not working?
- Use --verbosity to toggle between spinner and verbose Ginkgo output
- Ability to run Windows Operational Readiness tests from hydrophone HOT 1
- Confusing configuration file HOT 5
- Create an ADOPTERS.md to track who is using hydrophone HOT 1
- Lack of Support for Additional Conformance Test Flags HOT 10
- Improve `.gitignore`
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from hydrophone.