max-pods-to-evict-per-node default to 0? and loglevel default to 0? about descheduler

[aveshagarwal]

I will look into it today.

@aveshagarwal

I have to make some explains here that:

For the loglevel part, I expect there are something come out for the default installation parameters, but nothing currently, If you prefer to user -v explicitly, then I will open an installation issue for this.

For max-pod-to-evict-per-node part, I think better not make 0 as default value, If you want no pod will be evicted, this should be covered by dry-run mode.

How do you think?

[aveshagarwal]

For the loglevel part, I expect there are something come out for the default installation parameters, but nothing currently, If you prefer to user -v explicitly, then I will open an installation issue for this.

What you would like to see as default installation parameters?

For max-pod-to-evict-per-node part, I think better not make 0 as default value, If you want no pod will be evicted, this should be covered by dry-run mode.

I agree, though I would say 0 is incorrect configuration in the context of descheduler.

Also see my comment here: #87 (comment)

@aveshagarwal Anyway there should have something come out or people do not know if descheduler is working or not.

And currently have no -v option:
https://github.com/openshift/openshift-ansible/blob/master/roles/openshift_descheduler/templates/descheduler-cronjob.yaml.j2#L23

[aveshagarwal]

@wjiangjay can you close this if it is taken care of?

[aveshagarwal]

@wjiangjay ping is it ok to close this?

@aveshagarwal should be ok now.