Comments (7)
I think that in a controller pattern, we should use locks to control concurrency.
If necessary, I will submit a pull request to make the modifications. If not needed, I will close this issue.
from descheduler.
@googs1025 each plugin is run synchronously, along with each EvictPod request, so I don't think locks are necessary (unless you are referring to some sort of external lock implementation for running multiple descheduler instances?)
Are you currently hitting any concurrency issues with descheduler?
from descheduler.
@googs1025 each plugin is run synchronously, along with each EvictPod request, so I don't think locks are necessary (unless you are referring to some sort of external lock implementation for running multiple descheduler instances?)
Are you currently hitting any concurrency issues with descheduler?
thank you for reply!
No, I was just feeling a bit confused while reviewing the source code. I'm not sure if there is a multi-instance implementation, but typically, if there are multiple instances or concurrency involved, locks or the atomic package are commonly used.
The Evict method in the descheduler also follows the Kubernetes framework, right? If so, it should not involve any concurrency issues.
from descheduler.
The Evict method in the descheduler also follows the Kubernetes framework, right? If so, it should not involve any concurrency issues.
Yes, this just calls the kubernetes API so we don't need to worry about concurrency there
from descheduler.
ok, I'll closed this issue.
from descheduler.
/close
from descheduler.
@googs1025: Closing this issue.
In response to this:
/close
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.
from descheduler.
Related Issues (20)
- Please reopen #1383 HOT 1
- Option for LowNodeUtilization and HighNodeUtilization for node regex name filtering HOT 3
- Investigate `kind` replacement for e2e HOT 7
- Descheduler Pod stuck in crashloopback HOT 2
- RemovePodsViolatingNodeTaints with includedTaints HOT 1
- status.phase=Unknown not available in 1.29 release HOT 8
- KEP-1397: descheduler integration with evacuation API as an alternative to eviction API
- Bump Kubernetes dependencies to v1.30.0
- 1.30: Update version references in docs and readme
- Chart not available anymore HOT 2
- Descheduler not evicting anything when deployed with Helm chart as a deployment HOT 2
- CrashLoopBackOff 0.29.0 HOT 2
- 1.30: Update CI in test-infra HOT 1
- Create v0.30.0 tag on master HOT 1
- Promote v0.30.0 docker image
- Helm chart version update to v0.30.0 HOT 1
- Endless descheduling of pods with node affinity preferredDuringSchedulingIgnoredDuringExecution and enough resources available on not tainted node but not on a tainted node
- Default deschedulerPolicy in helm chart causes crashloop HOT 2
- Add a new extension point EvictPlugin to descheduling framework HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from descheduler.