Comments (27)
any more details, please expand, I would be interested in contributing
Lets say a pod was scheduled on a node where there is mismatch between pod's toleration and node's taints, and it could be due to that the pod was scheduled on a node whose taints were later updated. Since, pod's tolerations were only checked at the time admission, and later node's taints were updated, pod continued running on the node, so it only applies for NoSchedule taints.
In summary, it would work as follows:
- get a list of nods (which already exists)
- get a list of pods on each node (which already exists)
- Verify that the node's taints (NoSchedule) are still satisfied by its pods' tolerations.
- As per previous step, If not satisfied, evict the pod.
- If yes (still satisfied), continue checking other pods until you have reached the end of list of pods for that node.
- Repeat above for all nodes.
from descheduler.
any more details, please expand, I would be interested in contributing
from descheduler.
@seanmalloy @damemi looks like this issue hasn't been picked up in long time. Is it okay if I give it a try? will post my queries here if any.
/assign
from descheduler.
Thanks @damemi for clarifying, I guess this issue will be closed now 🙂
from descheduler.
@paktek123 Take a look at this issue for a use case currently implemented with Draino that could be replaced by descheduler: kubernetes/node-problem-detector#199 (comment)
from descheduler.
Thanks for the explanation, I will hopefully try to contribute next week
from descheduler.
Nice idea! It is also very useful for customizing the migration time of POD.
from descheduler.
Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale
.
Stale issues rot after an additional 30d of inactivity and eventually close.
If this issue is safe to close now please do so with /close
.
Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale
from descheduler.
Stale issues rot after 30d of inactivity.
Mark the issue as fresh with /remove-lifecycle rotten
.
Rotten issues close after an additional 30d of inactivity.
If this issue is safe to close now please do so with /close
.
Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle rotten
from descheduler.
Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen
.
Mark the issue as fresh with /remove-lifecycle rotten
.
Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/close
from descheduler.
@fejta-bot: Closing this issue.
In response to this:
Rotten issues close after 30d of inactivity.
Reopen the issue with/reopen
.
Mark the issue as fresh with/remove-lifecycle rotten
.Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/close
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.
from descheduler.
/reopen
from descheduler.
@damemi: Reopened this issue.
In response to this:
/reopen
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.
from descheduler.
Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen
.
Mark the issue as fresh with /remove-lifecycle rotten
.
Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/close
from descheduler.
@fejta-bot: Closing this issue.
In response to this:
Rotten issues close after 30d of inactivity.
Reopen the issue with/reopen
.
Mark the issue as fresh with/remove-lifecycle rotten
.Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/close
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.
from descheduler.
/reopen
from descheduler.
@isindir: You can't reopen an issue/PR unless you authored it or you are a collaborator.
In response to this:
/reopen
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.
from descheduler.
/reopen
from descheduler.
@seanmalloy: Reopened this issue.
In response to this:
/reopen
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.
from descheduler.
/remove-lifecycle rotten
/kind feature
from descheduler.
Please do!
from descheduler.
@damemi @aveshagarwal one query around this description mentioned here, Are we looking to add a new check in api itself like somewhere here: https://github.com/kubernetes-sigs/descheduler/tree/master/pkg/descheduler/node or this feature is going to be a new change w.r.t command line options as well maybe here: https://github.com/kubernetes-sigs/descheduler/tree/master/cmd/descheduler/app ?
from descheduler.
I'm not actually sure why this issue is still open, I might have mistakenly reopened it when it went stale... we have a Taints/Tolerations strategy that was merged out of this issue (https://github.com/kubernetes-sigs/descheduler#removepodsviolatingnodetaints)
Is there something that strategy is missing from the discussion here? Or can we close this?
from descheduler.
Just checking, but is it now possible to:
- Detect permanent node problems and set Node Conditions using the Node Problem Detector and the scheduler's
TaintNodesByCondition
functionality. - Configure Descheduler to deschedule pods based on taints to cordon and drain nodes when they exhibit the NPD's
KernelDeadlock
condition, or a variant ofKernelDeadlock
we callVolumeTaskHung
. - Let the Cluster Autoscaler scale down underutilised nodes, including the nodes Descheduler has drained.
If so, is there an example?
from descheduler.
@StevenACoffman yes, the descheduler will evict any pods that are currently running on a node that has any NoSchedule
taint that the pods do not tolerate. So, your use case should work with the RemovePodsViolatingNodeTaints
strategy
from descheduler.
/close
from descheduler.
@damemi: Closing this issue.
In response to this:
/close
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.
from descheduler.
Related Issues (20)
- Chart not available anymore HOT 2
- Descheduler not evicting anything when deployed with Helm chart as a deployment HOT 2
- CrashLoopBackOff 0.29.0 HOT 5
- 1.30: Update CI in test-infra HOT 1
- Create v0.30.0 tag on master HOT 1
- Promote v0.30.0 docker image
- Helm chart version update to v0.30.0 HOT 1
- Endless descheduling of pods with node affinity preferredDuringSchedulingIgnoredDuringExecution and enough resources available on not tainted node but not on a tainted node
- Default deschedulerPolicy in helm chart causes crashloop HOT 3
- Add a new extension point EvictPlugin to descheduling framework HOT 1
- unknown phase feature HOT 3
- Latest version does not work with helm chart anymore HOT 1
- `failed to convert Descheduler minor version to float` on start HOT 5
- `unknown field nodeAffinityType` error with v0.30.0 HOT 8
- KEP-1421: Make individual NodeFit predicates configurable
- Unable to create a profile err="profile \"test\" configures deschedule extension point of non-existing plugins: map[RemovePodsViolatingTopologySpreadConstraint:{}]" HOT 4
- otel: conflicting Schema URL HOT 4
- Enable Service in Descheduler without ClusterIP as None - Helm Chart HOT 3
- Unable to create a profile" err="unable to build DefaultEvictor plugin HOT 2
- The descheduler supports limiting the total number of pods evicted per rescheduling cycle HOT 3
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from descheduler.