Coder Social home page Coder Social logo

Comments (3)

DirectXMan12 avatar DirectXMan12 commented on May 26, 2024 1

/kind feature

I think that some sort of Ensure method could be useful -- pass an object to Ensure, and we ensure that it's either created or up-to-date. Not sure of the precise design, but I'd be happy to review PRs and such, if you've got time to submit one.

from controller-runtime.

calind avatar calind commented on May 26, 2024

I would be glad to attempt a PR, but there are some design issues to address first.

Sometimes you need the eventually existing object first from the apiserver so that you can update/sync only some fields. In order to do this, you need to call the Get method, so this CreateOrUpdate won't fit in any interfaces (Reader or Writer).

One workaround I'm employing right now is that I manually implement CreateOrUpdate right into the reconciler (see https://github.com/presslabs/wordpress-operator/blob/51ece534c606a998807d7049a942e5c9de701646/pkg/controller/wordpress/wordpress_controller.go#L89).

What are your thoughts about this?

from controller-runtime.

DirectXMan12 avatar DirectXMan12 commented on May 26, 2024

it could probably be a helper method in utils that takes in a Reader/Writer.

from controller-runtime.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.