Comments (5)
pwittrock
commented on May 26, 2024
1
See #13
from controller-runtime.
fanzhangio
commented on May 26, 2024
If all of the staticcheck, gosimple and unused are all enabled, it should use `megacheck instead, avoiding duplication.
from controller-runtime.
fanzhangio
commented on May 26, 2024
Summary of lint issues:
- defined but unused vars and functions.
Need 1) Comment out 2) implement usage - What could be a reasonable maxLength (
lll)?I refer to set **120** as docs might need a readable length. - Lots of duplicated codes, especially in tests
Refactor by encapsulation or extracting to common libs - Missing error check and var check
Need to refactor.
from controller-runtime.
fanzhangio
commented on May 26, 2024
FYI
pkg/controller/source/source.go:64:1:warning: log is unused (deadcode)
pkg/internal/admission/tls.go:31:1:warning: makeTLSConfig is unused (deadcode)
pkg/client/cache_test.go:1::warning: file is not goimported (goimports)
pkg/internal/admission/decode.go:1::warning: file is not goimported (goimports)
pkg/internal/admission/example_decode_test.go:1::warning: file is not goimported (goimports)pkg/internal/admission/handler.go:1::warning: file is not goimported (goimports)pkg/internal/admission/http.go:1::warning: file is not goimported (goimports)
pkg/client/cache.go:164::warning: cyclomatic complexity 14 of function (*singleObjectCache).List() is high (> 10) (gocyclo)
pkg/client/cache.go:34::warning: line is 88 characters (lll)
pkg/client/cache.go:53::warning: line is 101 characters (lll)
pkg/client/cache.go:62::warning: line is 111 characters (lll)
pkg/client/cache.go:63::warning: line is 86 characters (lll)
pkg/client/cache.go:68::warning: line is 93 characters (lll)
pkg/client/cache.go:71::warning: line is 95 characters (lll)
pkg/client/cache.go:80::warning: line is 107 characters (lll)
pkg/client/cache.go:95::warning: line is 89 characters (lll)
pkg/client/cache.go:98::warning: line is 104 characters (lll)
pkg/client/cache.go:104::warning: line is 94 characters (lll)
pkg/client/cache.go:131::warning: line is 93 characters (lll)
pkg/client/cache.go:157::warning: line is 92 characters (lll)
pkg/client/cache.go:164::warning: line is 100 characters (lll)
pkg/client/cache.go:175::warning: line is 96 characters (lll)
pkg/client/cache.go:176::warning: line is 108 characters (lll)
pkg/client/cache.go:178::warning: line is 95 characters (lll)
pkg/client/cache.go:213::warning: line is 94 characters (lll)
pkg/client/cache.go:214::warning: line is 83 characters (lll)
pkg/client/cache.go:216::warning: line is 93 characters (lll)
pkg/client/cache.go:224::warning: line is 87 characters (lll)
pkg/client/cache.go:225::warning: line is 90 characters (lll)
pkg/client/cache.go:226::warning: line is 94 characters (lll)
pkg/client/cache.go:227::warning: line is 93 characters (lll)
pkg/client/cache.go:228::warning: line is 98 characters (lll)
pkg/client/cache.go:229::warning: line is 109 characters (lll)
pkg/client/cache.go:237::warning: line is 85 characters (lll)
pkg/client/cache.go:253::warning: line is 97 characters (lll)
pkg/client/cache.go:302::warning: line is 88 characters (lll)
pkg/client/cache.go:303::warning: line is 81 characters (lll)
pkg/client/cache_test.go:76::warning: line is 84 characters (lll)
pkg/client/cache_test.go:83::warning: line is 92 characters (lll)
pkg/client/cache_test.go:84::warning: line is 121 characters (lll)
pkg/client/cache_test.go:98::warning: line is 83 characters (lll)
pkg/client/cache_test.go:103::warning: line is 106 characters (lll)
pkg/client/cache_test.go:108::warning: line is 107 characters (lll)
pkg/client/cache_test.go:112::warning: line is 89 characters (lll)
pkg/client/cache_test.go:113::warning: line is 100 characters (lll)
pkg/client/cache_test.go:118::warning: line is 83 characters (lll)
pkg/client/cache_test.go:122::warning: line is 93 characters (lll)
pkg/client/cache_test.go:127::warning: line is 163 characters (lll)
pkg/client/cache_test.go:131::warning: line is 102 characters (lll)
pkg/client/cache_test.go:134::warning: line is 153 characters (lll)
pkg/client/cache_test.go:138::warning: line is 117 characters (lll)
pkg/client/cache_test.go:146::warning: line is 85 characters (lll)
pkg/client/cache_test.go:150::warning: line is 88 characters (lll)
pkg/client/cache_test.go:155::warning: line is 104 characters (lll)
pkg/client/cache_test.go:160::warning: line is 82 characters (lll)
pkg/client/cache_test.go:164::warning: line is 93 characters (lll)
pkg/client/client.go:19::warning: line is 91 characters (lll)
pkg/client/client.go:50::warning: line is 81 characters (lll)
pkg/client/client.go:149::warning: line is 84 characters (lll)
pkg/client/client.go:163::warning: line is 89 characters (lll)
pkg/client/interfaces.go:40::warning: line is 86 characters (lll)
pkg/client/interfaces.go:58::warning: line is 81 characters (lll)
pkg/client/interfaces.go:59::warning: line is 83 characters (lll)
pkg/client/interfaces.go:60::warning: line is 82 characters (lll)
pkg/client/interfaces.go:61::warning: line is 87 characters (lll)
pkg/client/config/config.go:39::warning: line is 101 characters (lll)
pkg/client/config/config.go:44::warning: line is 82 characters (lll)
pkg/client/config/config.go:49::warning: line is 104 characters (lll)
pkg/client/config/config.go:67::warning: line is 82 characters (lll)
pkg/client/config/config.go:79::warning: line is 104 characters (lll)
pkg/client/config/config.go:89::warning: line is 96 characters (lll)
pkg/client/config/config.go:90::warning: line is 104 characters (lll)
pkg/client/config/config.go:100::warning: line is 101 characters (lll)
pkg/client/config/config.go:101::warning: line is 104 characters (lll)
pkg/client/config/config.go:113::warning: line is 106 characters (lll)
pkg/client/config/config.go:114::warning: line is 104 characters (lll)
pkg/client/config/config.go:128::warning: line is 111 characters (lll)
pkg/client/config/config.go:129::warning: line is 104 characters (lll)
pkg/client/config/doc.go:17::warning: line is 100 characters (lll)
pkg/controller/controller.go:44::warning: line is 105 characters (lll)
pkg/controller/controller.go:47::warning: line is 107 characters (lll)
pkg/controller/controller.go:51::warning: line is 108 characters (lll)
pkg/controller/controller.go:52::warning: line is 116 characters (lll)
pkg/controller/controller.go:54::warning: line is 102 characters (lll)
pkg/controller/controller.go:57::warning: line is 108 characters (lll)
pkg/controller/controller.go:58::warning: line is 91 characters (lll)
pkg/controller/controller.go:59::warning: line is 96 characters (lll)
pkg/controller/controller.go:61::warning: line is 106 characters (lll)
pkg/controller/controller.go:68::warning: line is 105 characters (lll)
pkg/controller/controller.go:71::warning: line is 107 characters (lll)
pkg/controller/controller.go:74::warning: line is 101 characters (lll)
pkg/controller/controller.go:75::warning: line is 83 characters (lll)
pkg/controller/controller.go:79::warning: line is 108 characters (lll)
pkg/controller/controller.go:82::warning: line is 86 characters (lll)
pkg/controller/controller.go:85::warning: line is 90 characters (lll)
pkg/controller/controller.go:88::warning: line is 113 characters (lll)
pkg/controller/controller.go:92::warning: line is 93 characters (lll)
pkg/controller/controller.go:99::warning: line is 106 characters (lll)
pkg/controller/controller.go:105::warning: line is 87 characters (lll)
pkg/controller/controller.go:108::warning: line is 118 characters (lll)
pkg/controller/controller.go:139::warning: line is 94 characters (lll)
pkg/controller/controller.go:155::warning: line is 93 characters (lll)
pkg/controller/controller.go:159::warning: line is 96 characters (lll)
pkg/controller/controller.go:182::warning: line is 95 characters (lll)
pkg/controller/controller.go:183::warning: line is 100 characters (lll)
pkg/controller/controller.go:207::warning: line is 91 characters (lll)
pkg/controller/controller.go:213::warning: line is 95 characters (lll)
pkg/controller/controller.go:214::warning: line is 100 characters (lll)
pkg/controller/controller.go:225::warning: line is 97 characters (lll)
pkg/controller/controller_integration_test.go:49::warning: line is 83 characters (lll)
pkg/controller/controller_integration_test.go:57::warning: line is 93 characters (lll)
pkg/controller/controller_integration_test.go:65::warning: line is 106 characters (lll)
pkg/controller/controller_integration_test.go:70::warning: line is 103 characters (lll)
pkg/controller/controller_integration_test.go:98::warning: line is 86 characters (lll)
pkg/controller/controller_integration_test.go:104::warning: line is 81 characters (lll)
pkg/controller/controller_integration_test.go:111::warning: line is 87 characters (lll)
pkg/controller/controller_integration_test.go:134::warning: line is 81 characters (lll)
pkg/controller/controller_integration_test.go:141::warning: line is 87 characters (lll)
pkg/controller/controller_integration_test.go:146::warning: line is 99 characters (lll)
pkg/controller/controller_manager.go:36::warning: line is 94 characters (lll)
pkg/controller/controller_manager.go:40::warning: line is 82 characters (lll)
pkg/controller/controller_manager.go:44::warning: line is 88 characters (lll)
pkg/controller/controller_manager.go:67::warning: line is 100 characters (lll)
pkg/controller/controller_manager.go:71::warning: line is 98 characters (lll)
pkg/controller/controller_manager.go:74::warning: line is 102 characters (lll)
pkg/controller/controller_manager.go:78::warning: line is 95 characters (lll)
pkg/controller/controller_manager.go:81::warning: line is 91 characters (lll)
pkg/controller/controller_manager.go:91::warning: line is 96 characters (lll)
pkg/controller/controller_manager.go:113::warning: line is 100 characters (lll)
pkg/controller/controller_manager.go:171::warning: line is 85 characters (lll)
pkg/controller/controller_manager.go:199::warning: line is 89 characters (lll)
pkg/controller/controller_manager.go:206::warning: line is 94 characters (lll)
pkg/controller/controller_manager.go:230::warning: line is 100 characters (lll)
pkg/controller/controller_manager.go:243::warning: line is 81 characters (lll)
pkg/controller/controller_manager.go:244::warning: line is 88 characters (lll)
pkg/controller/controller_suite_test.go:34::warning: line is 97 characters (lll)
pkg/controller/doc.go:18::warning: line is 102 characters (lll)
pkg/controller/doc.go:19::warning: line is 96 characters (lll)
pkg/controller/doc.go:23::warning: line is 115 characters (lll)
pkg/controller/doc.go:26::warning: line is 105 characters (lll)
pkg/controller/doc.go:29::warning: line is 95 characters (lll)
pkg/controller/doc.go:31::warning: line is 87 characters (lll)
pkg/controller/doc.go:35::warning: line is 95 characters (lll)
pkg/controller/doc.go:36::warning: line is 112 characters (lll)
pkg/controller/doc.go:39::warning: line is 114 characters (lll)
pkg/controller/doc.go:40::warning: line is 104 characters (lll)
pkg/controller/doc.go:43::warning: line is 85 characters (lll)
pkg/controller/doc.go:45::warning: line is 106 characters (lll)
pkg/controller/doc.go:47::warning: line is 98 characters (lll)
pkg/controller/doc.go:48::warning: line is 107 characters (lll)
pkg/controller/doc.go:55::warning: line is 100 characters (lll)
pkg/controller/doc.go:56::warning: line is 104 characters (lll)
pkg/controller/doc.go:59::warning: line is 101 characters (lll)
pkg/controller/doc.go:62::warning: line is 108 characters (lll)
pkg/controller/doc.go:66::warning: line is 105 characters (lll)
pkg/controller/doc.go:69::warning: line is 110 characters (lll)
pkg/controller/doc.go:73::warning: line is 102 characters (lll)
pkg/controller/doc.go:75::warning: line is 106 characters (lll)
pkg/controller/doc.go:80::warning: line is 112 characters (lll)
pkg/controller/doc.go:82::warning: line is 100 characters (lll)
pkg/controller/doc.go:84::warning: line is 116 characters (lll)
pkg/controller/doc.go:88::warning: line is 108 characters (lll)
pkg/controller/doc.go:95::warning: line is 108 characters (lll)
pkg/controller/doc.go:114::warning: line is 114 characters (lll)
pkg/controller/doc.go:115::warning: line is 107 characters (lll)
pkg/controller/doc.go:120::warning: line is 109 characters (lll)
pkg/controller/doc.go:121::warning: line is 91 characters (lll)
pkg/controller/doc.go:129::warning: line is 90 characters (lll)
pkg/controller/doc.go:131::warning: line is 104 characters (lll)
pkg/controller/doc.go:135::warning: line is 96 characters (lll)
pkg/controller/doc.go:137::warning: line is 84 characters (lll)
pkg/controller/doc.go:139::warning: line is 97 characters (lll)
pkg/controller/doc.go:143::warning: line is 105 characters (lll)
pkg/controller/doc.go:144::warning: line is 103 characters (lll)
pkg/controller/doc.go:145::warning: line is 98 characters (lll)
pkg/controller/doc.go:147::warning: line is 108 characters (lll)
pkg/controller/doc.go:149::warning: line is 92 characters (lll)
pkg/controller/doc.go:153::warning: line is 109 characters (lll)
pkg/controller/doc.go:155::warning: line is 106 characters (lll)
pkg/controller/doc.go:156::warning: line is 94 characters (lll)
pkg/controller/doc.go:163::warning: line is 113 characters (lll)
pkg/controller/doc.go:164::warning: line is 92 characters (lll)
pkg/controller/doc.go:166::warning: line is 110 characters (lll)
pkg/controller/doc.go:167::warning: line is 110 characters (lll)
pkg/controller/doc.go:172::warning: line is 104 characters (lll)
pkg/controller/doc.go:173::warning: line is 110 characters (lll)
pkg/controller/doc.go:176::warning: line is 106 characters (lll)
pkg/controller/example_test.go:30::warning: line is 109 characters (lll)
pkg/controller/example_test.go:33::warning: line is 90 characters (lll)
pkg/controller/example_test.go:40::warning: line is 97 characters (lll)
pkg/controller/example_test.go:49::warning: line is 101 characters (lll)
pkg/controller/example_test.go:51::warning: line is 90 characters (lll)
pkg/controller/example_test.go:59::warning: line is 87 characters (lll)
pkg/controller/controllertest/testing.go:29::warning: line is 119 characters (lll)
pkg/controller/controllertest/testing.go:41::warning: line is 109 characters (lll)
pkg/controller/controllertest/testing.go:51::warning: line is 85 characters (lll)
pkg/controller/controllertest/testing.go:59::warning: line is 82 characters (lll)
pkg/controller/controllertest/util.go:30::warning: line is 85 characters (lll)
pkg/controller/controllertest/util.go:59::warning: line is 98 characters (lll)
pkg/controller/controllertest/util.go:90::warning: line is 82 characters (lll)
pkg/controller/controllertest/util.go:91::warning: line is 120 characters (lll)
pkg/controller/event/event.go:35::warning: line is 89 characters (lll)
pkg/controller/event/event.go:41::warning: line is 88 characters (lll)
pkg/controller/event/event.go:56::warning: line is 90 characters (lll)
pkg/controller/event/event.go:61::warning: line is 120 characters (lll)
pkg/controller/event/event_suite_test.go:30::warning: line is 92 characters (lll)
pkg/controller/eventhandler/doc.go:18::warning: line is 121 characters (lll)
pkg/controller/eventhandler/doc.go:23::warning: line is 106 characters (lll)
pkg/controller/eventhandler/doc.go:25::warning: line is 125 characters (lll)
pkg/controller/eventhandler/doc.go:27::warning: line is 121 characters (lll)
pkg/controller/eventhandler/enqueue.go:31::warning: line is 100 characters (lll)
pkg/controller/eventhandler/enqueue.go:35::warning: line is 91 characters (lll)
pkg/controller/eventhandler/enqueue.go:37::warning: line is 84 characters (lll)
pkg/controller/eventhandler/enqueue.go:47::warning: line is 91 characters (lll)
pkg/controller/eventhandler/enqueue.go:54::warning: line is 88 characters (lll)
pkg/controller/eventhandler/enqueue.go:63::warning: line is 88 characters (lll)
pkg/controller/eventhandler/enqueue.go:68::warning: line is 91 characters (lll)
pkg/controller/eventhandler/enqueue.go:70::warning: line is 84 characters (lll)
pkg/controller/eventhandler/enqueue.go:80::warning: line is 93 characters (lll)
pkg/controller/eventhandler/enqueue.go:82::warning: line is 86 characters (lll)
pkg/controller/eventhandler/enqueue_mapped.go:29::warning: line is 93 characters (lll)
pkg/controller/eventhandler/enqueue_mapped.go:31::warning: line is 103 characters (lll)
pkg/controller/eventhandler/enqueue_mapped.go:39::warning: line is 97 characters (lll)
pkg/controller/eventhandler/enqueue_mapped.go:44::warning: line is 97 characters (lll)
pkg/controller/eventhandler/enqueue_mapped.go:50::warning: line is 97 characters (lll)
pkg/controller/eventhandler/enqueue_mapped.go:55::warning: line is 99 characters (lll)
pkg/controller/eventhandler/enqueue_mapped.go:59::warning: line is 99 characters (lll)
pkg/controller/eventhandler/enqueue_mapped.go:71::warning: line is 81 characters (lll)
pkg/controller/eventhandler/enqueue_owner.go:37::warning: line is 98 characters (lll)
pkg/controller/eventhandler/enqueue_owner.go:40::warning: line is 110 characters (lll)
pkg/controller/eventhandler/enqueue_owner.go:46::warning: line is 112 characters (lll)
pkg/controller/eventhandler/enqueue_owner.go:49::warning: line is 89 characters (lll)
pkg/controller/eventhandler/enqueue_owner.go:61::warning: line is 101 characters (lll)
pkg/controller/eventhandler/enqueue_owner.go:67::warning: line is 96 characters (lll)
pkg/controller/eventhandler/enqueue_owner.go:74::warning: line is 96 characters (lll)
pkg/controller/eventhandler/enqueue_owner.go:84::warning: line is 96 characters (lll)
pkg/controller/eventhandler/enqueue_owner.go:91::warning: line is 98 characters (lll)
pkg/controller/eventhandler/enqueue_owner.go:97::warning: line is 107 characters (lll)
pkg/controller/eventhandler/enqueue_owner.go:99::warning: line is 85 characters (lll)
pkg/controller/eventhandler/enqueue_owner.go:103::warning: line is 85 characters (lll)
pkg/controller/eventhandler/enqueue_owner.go:106::warning: line is 106 characters (lll)
pkg/controller/eventhandler/enqueue_owner.go:118::warning: line is 97 characters (lll)
pkg/controller/eventhandler/enqueue_owner.go:120::warning: line is 98 characters (lll)
pkg/controller/eventhandler/enqueue_owner.go:121::warning: line is 104 characters (lll)
pkg/controller/eventhandler/enqueue_owner.go:125::warning: line is 110 characters (lll)
pkg/controller/eventhandler/enqueue_owner.go:133::warning: line is 106 characters (lll)
pkg/controller/eventhandler/enqueue_owner.go:135::warning: line is 89 characters (lll)
pkg/controller/eventhandler/enqueue_owner.go:138::warning: line is 82 characters (lll)
pkg/controller/eventhandler/enqueue_owner.go:139::warning: line is 82 characters (lll)
pkg/controller/eventhandler/enqueue_owner.go:150::warning: line is 104 characters (lll)
pkg/controller/eventhandler/enqueue_owner.go:153::warning: line is 97 characters (lll)
pkg/controller/eventhandler/eventhandler.go:24::warning: line is 112 characters (lll)
pkg/controller/eventhandler/eventhandler.go:25::warning: line is 109 characters (lll)
pkg/controller/eventhandler/eventhandler.go:26::warning: line is 111 characters (lll)
pkg/controller/eventhandler/eventhandler.go:28::warning: line is 114 characters (lll)
pkg/controller/eventhandler/eventhandler.go:31::warning: line is 109 characters (lll)
pkg/controller/eventhandler/eventhandler.go:33::warning: line is 82 characters (lll)
pkg/controller/eventhandler/eventhandler.go:34::warning: line is 116 characters (lll)
pkg/controller/eventhandler/eventhandler.go:36::warning: line is 94 characters (lll)
pkg/controller/eventhandler/eventhandler.go:37::warning: line is 110 characters (lll)
pkg/controller/eventhandler/eventhandler.go:38::warning: line is 81 characters (lll)
pkg/controller/eventhandler/eventhandler.go:40::warning: line is 113 characters (lll)
pkg/controller/eventhandler/eventhandler.go:52::warning: line is 108 characters (lll)
pkg/controller/eventhandler/eventhandler.go:100::warning: line is 81 characters (lll)
pkg/controller/eventhandler/eventhandler_suite_test.go:30::warning: line is 99 characters (lll)
pkg/controller/eventhandler/eventhandler_test.go:48::warning: line is 110 characters (lll)
pkg/controller/eventhandler/eventhandler_test.go:60::warning: line is 92 characters (lll)
pkg/controller/eventhandler/eventhandler_test.go:65::warning: line is 110 characters (lll)
pkg/controller/eventhandler/eventhandler_test.go:77::warning: line is 92 characters (lll)
pkg/controller/eventhandler/eventhandler_test.go:82::warning: line is 94 characters (lll)
pkg/controller/eventhandler/eventhandler_test.go:101::warning: line is 93 characters (lll)
pkg/controller/eventhandler/eventhandler_test.go:107::warning: line is 95 characters (lll)
pkg/controller/eventhandler/eventhandler_test.go:112::warning: line is 111 characters (lll)
pkg/controller/eventhandler/eventhandler_test.go:123::warning: line is 92 characters (lll)
pkg/controller/eventhandler/eventhandler_test.go:129::warning: line is 90 characters (lll)
pkg/controller/eventhandler/eventhandler_test.go:138::warning: line is 90 characters (lll)
pkg/controller/eventhandler/eventhandler_test.go:154::warning: line is 95 characters (lll)
pkg/controller/eventhandler/eventhandler_test.go:164::warning: line is 93 characters (lll)
pkg/controller/eventhandler/eventhandler_test.go:169::warning: line is 90 characters (lll)
pkg/controller/eventhandler/eventhandler_test.go:178::warning: line is 91 characters (lll)
pkg/controller/eventhandler/eventhandler_test.go:190::warning: line is 87 characters (lll)
pkg/controller/eventhandler/eventhandler_test.go:193::warning: line is 96 characters (lll)
pkg/controller/eventhandler/eventhandler_test.go:225::warning: line is 87 characters (lll)
pkg/controller/eventhandler/eventhandler_test.go:228::warning: line is 96 characters (lll)
pkg/controller/eventhandler/eventhandler_test.go:260::warning: line is 94 characters (lll)
pkg/controller/eventhandler/eventhandler_test.go:268::warning: line is 97 characters (lll)
pkg/controller/eventhandler/eventhandler_test.go:272::warning: line is 96 characters (lll)
pkg/controller/eventhandler/eventhandler_test.go:275::warning: line is 96 characters (lll)
pkg/controller/eventhandler/eventhandler_test.go:308::warning: line is 88 characters (lll)
pkg/controller/eventhandler/eventhandler_test.go:311::warning: line is 96 characters (lll)
pkg/controller/eventhandler/eventhandler_test.go:345::warning: line is 90 characters (lll)
pkg/controller/eventhandler/eventhandler_test.go:367::warning: line is 94 characters (lll)
pkg/controller/eventhandler/eventhandler_test.go:370::warning: line is 90 characters (lll)
pkg/controller/eventhandler/eventhandler_test.go:392::warning: line is 94 characters (lll)
pkg/controller/eventhandler/eventhandler_test.go:395::warning: line is 93 characters (lll)
pkg/controller/eventhandler/eventhandler_test.go:430::warning: line is 95 characters (lll)
pkg/controller/eventhandler/eventhandler_test.go:434::warning: line is 98 characters (lll)
pkg/controller/eventhandler/eventhandler_test.go:437::warning: line is 91 characters (lll)
pkg/controller/eventhandler/eventhandler_test.go:459::warning: line is 94 characters (lll)
pkg/controller/eventhandler/eventhandler_test.go:462::warning: line is 93 characters (lll)
pkg/controller/eventhandler/eventhandler_test.go:510::warning: line is 94 characters (lll)
pkg/controller/eventhandler/eventhandler_test.go:527::warning: line is 90 characters (lll)
pkg/controller/eventhandler/eventhandler_test.go:571::warning: line is 96 characters (lll)
pkg/controller/eventhandler/eventhandler_test.go:574::warning: line is 90 characters (lll)
pkg/controller/eventhandler/eventhandler_test.go:652::warning: line is 96 characters (lll)
pkg/controller/eventhandler/eventhandler_test.go:655::warning: line is 96 characters (lll)
pkg/controller/eventhandler/eventhandler_test.go:658::warning: line is 96 characters (lll)
pkg/controller/eventhandler/eventhandler_test.go:795::warning: line is 91 characters (lll)
pkg/controller/eventhandler/eventhandler_test.go:804::warning: line is 87 characters (lll)
pkg/controller/eventhandler/eventhandler_test.go:827::warning: line is 91 characters (lll)
pkg/controller/eventhandler/eventhandler_test.go:837::warning: line is 88 characters (lll)
pkg/controller/eventhandler/eventhandler_test.go:857::warning: line is 91 characters (lll)
pkg/controller/eventhandler/eventhandler_test.go:866::warning: line is 87 characters (lll)
pkg/controller/eventhandler/eventhandler_test.go:877::warning: line is 81 characters (lll)
pkg/controller/eventhandler/eventhandler_test.go:883::warning: line is 93 characters (lll)
pkg/controller/eventhandler/eventhandler_test.go:892::warning: line is 89 characters (lll)
pkg/controller/eventhandler/example_test.go:33::warning: line is 94 characters (lll)
pkg/controller/eventhandler/example_test.go:43::warning: line is 99 characters (lll)
pkg/controller/eventhandler/example_test.go:56::warning: line is 102 characters (lll)
pkg/controller/eventhandler/example_test.go:63::warning: line is 95 characters (lll)
pkg/controller/predicate/doc.go:18::warning: line is 116 characters (lll)
pkg/controller/predicate/example_test.go:26::warning: line is 99 characters (lll)
pkg/controller/predicate/predicate_suite_test.go:30::warning: line is 96 characters (lll)
pkg/controller/reconcile/doc.go:18::warning: line is 84 characters (lll)
pkg/controller/reconcile/example_test.go:26::warning: line is 101 characters (lll)
pkg/controller/reconcile/example_test.go:34::warning: line is 105 characters (lll)
pkg/controller/reconcile/reconcile.go:25::warning: line is 82 characters (lll)
pkg/controller/reconcile/reconcile.go:29::warning: line is 98 characters (lll)
pkg/controller/reconcile/reconcile.go:30::warning: line is 111 characters (lll)
pkg/controller/reconcile/reconcile.go:38::warning: line is 106 characters (lll)
pkg/controller/reconcile/reconcile.go:39::warning: line is 100 characters (lll)
pkg/controller/reconcile/reconcile.go:41::warning: line is 110 characters (lll)
pkg/controller/reconcile/reconcile.go:42::warning: line is 101 characters (lll)
pkg/controller/reconcile/reconcile.go:44::warning: line is 105 characters (lll)
pkg/controller/reconcile/reconcile.go:45::warning: line is 97 characters (lll)
pkg/controller/reconcile/reconcile.go:50::warning: line is 100 characters (lll)
pkg/controller/reconcile/reconcile.go:69::warning: line is 107 characters (lll)
pkg/controller/reconcile/reconcile.go:71::warning: line is 98 characters (lll)
pkg/controller/reconcile/reconcile.go:72::warning: line is 106 characters (lll)
pkg/controller/reconcile/reconcile.go:75::warning: line is 87 characters (lll)
pkg/controller/reconcile/reconcile_suite_test.go:30::warning: line is 96 characters (lll)
pkg/controller/reconcile/reconcile_test.go:30::warning: line is 82 characters (lll)
pkg/controller/reconcile/reconcile_test.go:38::warning: line is 83 characters (lll)
pkg/controller/reconcile/reconcile_test.go:58::warning: line is 83 characters (lll)
pkg/controller/source/doc.go:18::warning: line is 81 characters (lll)
pkg/controller/source/example_test.go:29::warning: line is 103 characters (lll)
pkg/controller/source/example_test.go:38::warning: line is 117 characters (lll)
pkg/controller/source/source.go:34::warning: line is 119 characters (lll)
pkg/controller/source/source.go:35::warning: line is 82 characters (lll)
pkg/controller/source/source.go:37::warning: line is 108 characters (lll)
pkg/controller/source/source.go:39::warning: line is 121 characters (lll)
pkg/controller/source/source.go:41::warning: line is 114 characters (lll)
pkg/controller/source/source.go:42::warning: line is 88 characters (lll)
pkg/controller/source/source.go:44::warning: line is 111 characters (lll)
pkg/controller/source/source.go:46::warning: line is 96 characters (lll)
pkg/controller/source/source.go:49::warning: line is 86 characters (lll)
pkg/controller/source/source.go:50::warning: line is 89 characters (lll)
pkg/controller/source/source.go:66::warning: line is 114 characters (lll)
pkg/controller/source/source.go:77::warning: line is 110 characters (lll)
pkg/controller/source/source.go:79::warning: line is 101 characters (lll)
pkg/controller/source/source.go:92::warning: line is 92 characters (lll)
pkg/controller/source/source.go:97::warning: line is 96 characters (lll)
pkg/controller/source/source.go:103::warning: line is 106 characters (lll)
pkg/controller/source/source_integration_test.go:53::warning: line is 91 characters (lll)
pkg/controller/source/source_integration_test.go:106::warning: line is 84 characters (lll)
pkg/controller/source/source_integration_test.go:111::warning: line is 84 characters (lll)
pkg/controller/source/source_integration_test.go:116::warning: line is 84 characters (lll)
pkg/controller/source/source_integration_test.go:142::warning: line is 88 characters (lll)
pkg/controller/source/source_integration_test.go:149::warning: line is 88 characters (lll)
pkg/controller/source/source_integration_test.go:162::warning: line is 88 characters (lll)
pkg/controller/source/source_integration_test.go:173::warning: line is 88 characters (lll)
pkg/controller/source/source_integration_test.go:189::warning: line is 88 characters (lll)
pkg/controller/source/source_integration_test.go:196::warning: line is 88 characters (lll)
pkg/controller/source/source_suite_test.go:34::warning: line is 93 characters (lll)
pkg/controller/source/source_test.go:25::warning: line is 83 characters (lll)
pkg/controller/source/source_test.go:63::warning: line is 94 characters (lll)
pkg/controller/source/source_test.go:69::warning: line is 82 characters (lll)
pkg/controller/source/source_test.go:104::warning: line is 94 characters (lll)
pkg/controller/source/source_test.go:110::warning: line is 82 characters (lll)
pkg/controller/source/source_test.go:114::warning: line is 82 characters (lll)
pkg/controller/source/source_test.go:154::warning: line is 94 characters (lll)
pkg/controller/source/source_test.go:168::warning: line is 82 characters (lll)
pkg/controller/source/source_test.go:193::warning: line is 94 characters (lll)
pkg/controller/source/internal/eventsource.go:38::warning: line is 102 characters (lll)
pkg/controller/source/internal/eventsource.go:131::warning: line is 96 characters (lll)
pkg/controller/source/internal/eventsource.go:134::warning: line is 97 characters (lll)
pkg/controller/source/internal/eventsource.go:138::warning: line is 106 characters (lll)
pkg/controller/source/internal/eventsource.go:141::warning: line is 85 characters (lll)
pkg/controller/source/internal/internal_suite_test.go:30::warning: line is 95 characters (lll)
pkg/controller/source/internal/internal_test.go:77::warning: line is 86 characters (lll)
pkg/controller/source/internal/internal_test.go:90::warning: line is 86 characters (lll)
pkg/controller/source/internal/internal_test.go:109::warning: line is 86 characters (lll)
pkg/controller/source/internal/internal_test.go:127::warning: line is 86 characters (lll)
pkg/controller/source/internal/internal_test.go:162::warning: line is 81 characters (lll)
pkg/internal/admission/decode.go:32::warning: line is 117 characters (lll)
pkg/internal/admission/example_admissionfunc_test.go:29::warning: line is 89 characters (lll)
pkg/internal/admission/example_admissionfunc_test.go:31::warning: line is 89 characters (lll)
pkg/internal/admission/example_decode_test.go:29::warning: line is 88 characters (lll)
pkg/internal/admission/example_handlefunc_test.go:29::warning: line is 88 characters (lll)
pkg/internal/admission/example_handlefunc_test.go:30::warning: line is 109 characters (lll)
pkg/internal/admission/example_handlefunc_test.go:45::warning: line is 88 characters (lll)
pkg/internal/admission/example_handlefunc_test.go:47::warning: line is 102 characters (lll)
pkg/internal/admission/example_test.go:29::warning: line is 88 characters (lll)
pkg/internal/admission/example_test.go:30::warning: line is 109 characters (lll)
pkg/internal/admission/handler.go:35::warning: line is 94 characters (lll)
pkg/internal/admission/handler.go:50::warning: line is 109 characters (lll)
pkg/internal/admission/handler.go:51::warning: line is 85 characters (lll)
pkg/internal/admission/handler.go:59::warning: line is 109 characters (lll)
pkg/internal/admission/response.go:24::warning: line is 82 characters (lll)
pkg/internal/apiutil/apimachinery.go:27::warning: line is 112 characters (lll)
pkg/internal/apiutil/apimachinery.go:28::warning: line is 96 characters (lll)
pkg/internal/apiutil/apimachinery.go:34::warning: line is 111 characters (lll)
pkg/internal/apiutil/apimachinery.go:38::warning: line is 101 characters (lll)
pkg/internal/apiutil/apimachinery.go:44::warning: line is 89 characters (lll)
pkg/internal/apiutil/apimachinery.go:49::warning: line is 96 characters (lll)
pkg/internal/apiutil/apimachinery.go:51::warning: line is 133 characters (lll)
pkg/internal/informer/cache.go:23::warning: line is 86 characters (lll)
pkg/internal/informer/cache.go:26::warning: line is 99 characters (lll)
pkg/internal/informer/cache.go:29::warning: line is 97 characters (lll)
pkg/internal/informer/cache.go:34::warning: line is 87 characters (lll)
pkg/internal/informer/cache.go:41::warning: line is 85 characters (lll)
pkg/internal/informer/cache.go:46::warning: line is 108 characters (lll)
pkg/internal/informer/cache.go:47::warning: line is 98 characters (lll)
pkg/internal/informer/cache.go:88::warning: line is 112 characters (lll)
pkg/internal/informer/cache.go:94::warning: line is 115 characters (lll)
pkg/internal/informer/cache.go:104::warning: line is 102 characters (lll)
pkg/internal/informer/cache.go:114::warning: line is 131 characters (lll)
pkg/internal/informer/informertest/fake_cache.go:38::warning: line is 105 characters (lll)
pkg/internal/informer/informertest/fake_cache.go:47::warning: line is 112 characters (lll)
pkg/internal/informer/informertest/fake_cache.go:60::warning: line is 92 characters (lll)
pkg/internal/informer/informertest/fake_cache.go:70::warning: line is 102 characters (lll)
pkg/internal/informer/informertest/fake_cache.go:75::warning: line is 99 characters (lll)
pkg/internal/informer/informertest/fake_cache.go:88::warning: line is 121 characters (lll)
pkg/runtime/inject/doc.go:18::warning: line is 104 characters (lll)
pkg/runtime/inject/doc.go:19::warning: line is 112 characters (lll)
pkg/runtime/inject/inject.go:26::warning: line is 110 characters (lll)
pkg/runtime/inject/inject.go:32::warning: line is 97 characters (lll)
pkg/runtime/inject/inject.go:41::warning: line is 104 characters (lll)
pkg/runtime/inject/inject.go:47::warning: line is 88 characters (lll)
pkg/runtime/inject/inject.go:56::warning: line is 104 characters (lll)
pkg/runtime/inject/inject.go:62::warning: line is 88 characters (lll)
pkg/runtime/inject/inject.go:71::warning: line is 104 characters (lll)
pkg/runtime/inject/inject.go:77::warning: line is 88 characters (lll)
pkg/runtime/log/deleg.go:18::warning: line is 83 characters (lll)
pkg/runtime/log/deleg.go:28::warning: line is 91 characters (lll)
pkg/runtime/signals/doc.go:17::warning: line is 82 characters (lll)
pkg/runtime/signals/signal.go:23::warning: line is 83 characters (lll)
pkg/runtime/signals/signal.go:24::warning: line is 85 characters (lll)
pkg/test/doc.go:17::warning: line is 91 characters (lll)
pkg/test/ginkgo.go:29::warning: line is 106 characters (lll)
pkg/test/ginkgo.go:35::warning: line is 104 characters (lll)
pkg/test/ginkgo.go:50::warning: line is 106 characters (lll)
pkg/test/ginkgo.go:51::warning: line is 88 characters (lll)
pkg/test/server.go:23::warning: line is 82 characters (lll)
pkg/test/server.go:36::warning: line is 108 characters (lll)
pkg/test/server.go:49::warning: line is 103 characters (lll)
pkg/test/server.go:53::warning: line is 83 characters (lll)
pkg/test/server.go:78::warning: line is 89 characters (lll)
pkg/controller/predicate/predicate_test.go:60::warning: duplicate of pkg/controller/predicate/predicate_test.go:124-149 (dupl)
pkg/controller/predicate/predicate_test.go:124::warning: duplicate of pkg/controller/predicate/predicate_test.go:151-176 (dupl)
pkg/controller/predicate/predicate_test.go:151::warning: duplicate of pkg/controller/predicate/predicate_test.go:60-85 (dupl)
pkg/controller/eventhandler/eventhandler_test.go:345::warning: duplicate of pkg/controller/eventhandler/eventhandler_test.go:370-393 (dupl)
pkg/controller/eventhandler/eventhandler_test.go:370::warning: duplicate of pkg/controller/eventhandler/eventhandler_test.go:437-460 (dupl)
pkg/controller/eventhandler/eventhandler_test.go:437::warning: duplicate of pkg/controller/eventhandler/eventhandler_test.go:345-368 (dupl)
pkg/controller/eventhandler/eventhandler_test.go:48::warning: duplicate of pkg/controller/eventhandler/eventhandler_test.go:65-80 (dupl)
pkg/controller/eventhandler/eventhandler_test.go:65::warning: duplicate of pkg/controller/eventhandler/eventhandler_test.go:112-126 (dupl)
pkg/controller/eventhandler/eventhandler_test.go:112::warning: duplicate of pkg/controller/eventhandler/eventhandler_test.go:48-63 (dupl)
pkg/controller/eventhandler/eventhandler_test.go:190::warning: duplicate of pkg/controller/eventhandler/eventhandler_test.go:225-258 (dupl)
pkg/controller/eventhandler/eventhandler_test.go:225::warning: duplicate of pkg/controller/eventhandler/eventhandler_test.go:308-341 (dupl)
pkg/controller/eventhandler/eventhandler_test.go:308::warning: duplicate of pkg/controller/eventhandler/eventhandler_test.go:190-223 (dupl)
pkg/controller/source/internal/internal_test.go:77::warning: duplicate of pkg/controller/source/internal/internal_test.go:109-117 (dupl)
pkg/controller/source/internal/internal_test.go:109::warning: duplicate of pkg/controller/source/internal/internal_test.go:127-134 (dupl)
pkg/controller/source/internal/internal_test.go:127::warning: duplicate of pkg/controller/source/internal/internal_test.go:77-84 (dupl)
pkg/controller/eventhandler/eventhandler_test.go:683::warning: duplicate of pkg/controller/eventhandler/eventhandler_test.go:704-724 (dupl)
pkg/controller/eventhandler/eventhandler_test.go:704::warning: duplicate of pkg/controller/eventhandler/eventhandler_test.go:746-766 (dupl)
pkg/controller/eventhandler/eventhandler_test.go:746::warning: duplicate of pkg/controller/eventhandler/eventhandler_test.go:683-703 (dupl)
pkg/controller/source/source_test.go:69::warning: duplicate of pkg/controller/source/source_test.go:168-174 (dupl)
pkg/controller/source/source_test.go:168::warning: duplicate of pkg/controller/source/source_test.go:69-75 (dupl)
pkg/controller/eventhandler/eventhandler_test.go:789::warning: duplicate of pkg/controller/eventhandler/eventhandler_test.go:851-864 (dupl)
pkg/controller/eventhandler/eventhandler_test.go:851::warning: duplicate of pkg/controller/eventhandler/eventhandler_test.go:877-890 (dupl)
pkg/controller/eventhandler/eventhandler_test.go:877::warning: duplicate of pkg/controller/eventhandler/eventhandler_test.go:789-802 (dupl)
pkg/controller/source/internal/internal_test.go:76::warning: duplicate of pkg/controller/source/internal/internal_test.go:108-120 (dupl)
pkg/controller/source/internal/internal_test.go:108::warning: duplicate of pkg/controller/source/internal/internal_test.go:76-87 (dupl)
pkg/controller/eventhandler/eventhandler_test.go:345::warning: duplicate of pkg/controller/eventhandler/eventhandler_test.go:370-393 (dupl)
pkg/controller/eventhandler/eventhandler_test.go:370::warning: duplicate of pkg/controller/eventhandler/eventhandler_test.go:437-460 (dupl)
pkg/controller/eventhandler/eventhandler_test.go:437::warning: duplicate of pkg/controller/eventhandler/eventhandler_test.go:489-511 (dupl)
pkg/controller/eventhandler/eventhandler_test.go:489::warning: duplicate of pkg/controller/eventhandler/eventhandler_test.go:345-368 (dupl)
pkg/client/cache_test.go:116::warning: duplicate of pkg/client/cache_test.go:158-165 (dupl)
pkg/client/cache_test.go:158::warning: duplicate of pkg/client/cache_test.go:116-123 (dupl)
pkg/controller/predicate/predicate_test.go:93::warning: duplicate of pkg/controller/predicate/predicate_test.go:109-116 (dupl)
pkg/controller/predicate/predicate_test.go:109::warning: duplicate of pkg/controller/predicate/predicate_test.go:93-100 (dupl)
pkg/controller/controller_integration_test.go:79::warning: duplicate of pkg/controller/source/source_integration_test.go:83-101 (dupl)
pkg/controller/source/source_integration_test.go:83::warning: duplicate of pkg/controller/controller_integration_test.go:79-97 (dupl)
pkg/controller/eventhandler/enqueue.go:35::warning: duplicate of pkg/controller/eventhandler/enqueue.go:68-77 (dupl)
pkg/controller/eventhandler/enqueue.go:68::warning: duplicate of pkg/controller/eventhandler/enqueue.go:80-89 (dupl)
pkg/controller/eventhandler/enqueue.go:80::warning: duplicate of pkg/controller/eventhandler/enqueue.go:35-44 (dupl)
pkg/controller/eventhandler/eventhandler_test.go:770::warning: duplicate of pkg/controller/source/internal/internal_test.go:39-56 (dupl)
pkg/controller/source/internal/internal_test.go:39::warning: duplicate of pkg/controller/eventhandler/eventhandler_test.go:770-787 (dupl)
pkg/internal/admission/example_handlefunc_test.go:30::warning: duplicate of pkg/internal/admission/example_handlefunc_test.go:47-58 (dupl)
pkg/internal/admission/example_handlefunc_test.go:47::warning: duplicate of pkg/internal/admission/example_test.go:30-41 (dupl)
pkg/internal/admission/example_test.go:30::warning: duplicate of pkg/internal/admission/example_handlefunc_test.go:30-41 (dupl)
pkg/controller/eventhandler/enqueue_owner.go:45:26:warning: struct of size 64 could be 56 (maligned)
pkg/internal/informer/cache.go:48:30:warning: struct of size 208 could be 200 (maligned)
pkg/controller/controller_manager.go:104:15:warning: error return value not checked (cm.injectInto(r)) (errcheck)
pkg/controller/controller_manager.go:167:20:warning: error return value not checked (cm.informers.Start(stop)) (errcheck)
pkg/controller/controller_manager.go:227:26:warning: error return value not checked (cm.informers.InformerFor(&v1.Deployment{})) (errcheck)
pkg/test/server.go:46:22:warning: error return value not checked (te.ControlPlane.Stop()) (errcheck)
pkg/controller/source/source.go:64:5:warning: unused variable or constant log (varcheck)
pkg/controller/controller_suite_test.go:40:5:warning: unused variable or constant icache (varcheck)
pkg/controller/controller.go:97:2:warning: unused struct field github.com/kubernetes-sigs/controller-runtime/pkg/controller.controller.once (structcheck)
pkg/controller/eventhandler/enqueue_owner.go:56:2:warning: unused struct field github.com/kubernetes-sigs/controller-runtime/pkg/controller/eventhandler.EnqueueOwnerHandler.kindOk (structcheck)
pkg/internal/informer/informertest/fake_cache.go:88:66:warning: parameter obj is unused (unparam)
WARNING: deadline exceeded by linter safesql (try increasing --deadline)
WARNING: deadline exceeded by linter megacheck (try increasing --deadline)from controller-runtime.
pwittrock
commented on May 26, 2024
@fanzhangio Lets ignore line length and dupl for now. The others seem a lot more valuable.
from controller-runtime.
Related Issues (20)
- Allow modifying context per `Reconcile(ctx context.Context, req ctrl.Request)` HOT 3
- Incompatibility Issue with controller-runtime Version Pinning and envtest Setup - It is requiring go 1.22 when the latest release still using go 1.21 as old project versions HOT 3
- Unstructured converter panics if the destination struct contains private fields HOT 3
- Multi Cluster Example / Pattern HOT 9
- Panic in `runnableGroup`'s `Add` and `StopAndWait` due to a data race HOT 1
- Cannot run / install specific versions of setup-envtest due to missing submodule tag HOT 2
- Data race during manager shutdown HOT 2
- Add a validation script to verify go.mod is in sync with k/k HOT 3
- Enhancement of Authentication and Authorization Filters to Allow Custom Configurations and Stability Improvements HOT 4
- Data race with various client APIs HOT 3
- Allow to ignore globalPredicates for specific resources HOT 1
- Undefined SwitchMetric Error with client-go 0.30.0 in Go Vet HOT 8
- Use setup-envtest from (test) code HOT 18
- Semantic version is incorrect for setup-envtest HOT 3
- Default Liveness and Readiness endpoints return 404
- Optimize patches returned by Defaulter
- DefaultLabelSelector overrides ByObject.Label in DefaultNamespaces
- Does controller-runtime support that multiple controllers share one Manager and use different clients(RBAC)? HOT 6
- Add a way to grab the controller name out of the reconcile context HOT 1
- failed to install setup-envtest HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from controller-runtime.