Coder Social home page Coder Social logo

Comments (14)

fejta-bot avatar fejta-bot commented on June 5, 2024

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

from controller-runtime.

fejta-bot avatar fejta-bot commented on June 5, 2024

Stale issues rot after 30d of inactivity.
Mark the issue as fresh with /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle rotten

from controller-runtime.

DirectXMan12 avatar DirectXMan12 commented on June 5, 2024

/remove-lifecycle rotten
/kind feature
/priority important-longterm

from controller-runtime.

fejta-bot avatar fejta-bot commented on June 5, 2024

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

from controller-runtime.

DirectXMan12 avatar DirectXMan12 commented on June 5, 2024

/lifecycle frozen

from controller-runtime.

DirectXMan12 avatar DirectXMan12 commented on June 5, 2024

perhaps a predicate?

from controller-runtime.

vincepri avatar vincepri commented on June 5, 2024

/kind design
feature should have a spec design before implementation

from controller-runtime.

vincepri avatar vincepri commented on June 5, 2024

/help

from controller-runtime.

k8s-ci-robot avatar k8s-ci-robot commented on June 5, 2024

@vincepri:
This request has been marked as needing help from a contributor.

Please ensure the request meets the requirements listed here.

If this request no longer meets these requirements, the label can be removed
by commenting with the /remove-help command.

In response to this:

/help

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

from controller-runtime.

alvaroaleman avatar alvaroaleman commented on June 5, 2024

I believe a predicate would not solve the problem, because the object can get deleted while its in the workqueue, so ppl would still have to have the check if the object exists by the time their Reconcile get called.

from controller-runtime.

fejta-bot avatar fejta-bot commented on June 5, 2024

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

from controller-runtime.

vincepri avatar vincepri commented on June 5, 2024

/lifecycle frozen

from controller-runtime.

vincepri avatar vincepri commented on June 5, 2024

/remove-lifecycle frozen
/close

Closing this as in there has been no updates on this issue for a while. If there is enough interest, we could provide an optional predicate or function that does the same, although I would assume that most controllers might want to do the check on their own, like @alvaroaleman pointed out.

from controller-runtime.

k8s-ci-robot avatar k8s-ci-robot commented on June 5, 2024

@vincepri: Closing this issue.

In response to this:

/remove-lifecycle frozen
/close

Closing this as in there has been no updates on this issue for a while. If there is enough interest, we could provide an optional predicate or function that does the same, although I would assume that most controllers might want to do the check on their own, like @alvaroaleman pointed out.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

from controller-runtime.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.