Support source.Kind for unstructured objects about controller-runtime

[shawn-hurley]

I am interested in helping with this issue. I was wondering if you had thoughts on how to handle this already or if a design doc or something similar has been created?

[pwittrock]

@shawn-hurley Not yet, though I think the interface shouldn't change, it should just accept unstructured objects. Would you be willing to put together a 1-2 page doc on the topic before getting started?

From a high level:

• The client commands and controller.Watch / source. Kind should accept unstructured objects (they already do)
  • Unstructured objects must have the GVK specified in the object
  • client / source should work with the unstructured object the way they would with other runtime.Objects

One question is whether the cache should be shared between unstructured and hard-coded objects for the same GVK. As long as it is consistent and predictable I think either way is good.

[pwittrock]

@shawn-hurley FWIW, this might already work. I think the first task is to try it and see if it works or not, then dig in deeper.

[shawn-hurley]

@pwittrock I think that it would work with a single unstructured type, but if you used two then the client-cache: https://github.com/kubernetes-sigs/controller-runtime/blob/master/pkg/client/client_cache.go#L79-L84 will overwrite the GVK for one fo the types.

Am I correct in that reading of the code?

I will work on getting an example to test this theory as well.

Thanks!

[DirectXMan12]

aah, yeah, we probably would need a key that's like TypeOf(obj) unless IsUnstructured(obj) else SpecialUnstructuredKeyWithKind.

[DirectXMan12]

or have a separate map for unstructured objects.

[shawn-hurley]

@pwittrock @DirectXMan12 I am working on getting an example of using two different unstructured types to test this theory out and to have something to test with.

Which would you prefer the second map if the type is Unstructured or some other mechanism? I would think that two maps might make it more clear?

[DirectXMan12]

Two maps is probably clearer.