How should I inject other dependencies into reconcilers? about controller-runtime

[DirectXMan12]

🚂 🚋 🚋 <-- the dependency injection train

At some point during the design of this framework, we had a discussion about dependency injection, and the upshot was that we were really hesitant about adding full-scale generic dependency injection, and decided to avoid it, and have a couple tightly scoped cases inside the library that didn't leak out (with the exception of InjectClient). I'm (so far) still on board with that sentiment.

My initial suggestion would just be to pass the logger in at object construction. If that's not possible for whatever reason, you could totally implement something similar to what we do internally -- things that need a Foo implement an InjectFoo interface, and then the code that has a Foo and a handle to those things checks each thing to see if it implements InjectFoo, and if it does, it calls that. Can you provide a bit more information on your particular usecase? Maybe some real or mock code that you're trying to achieve?

[grantr]

Thanks for the background, I think the instinct to be wary of dependency injection is reasonable. Sounds like it's essentially an internal implementation detail. Since it's possible to call mrg.GetClient() when creating a controller, is there really a need to expose InjectClient? Maybe we (as users of the library) should drop our usage of that.

[DirectXMan12]

I think the goal of that was probably to allow users to not have to write constructors -- with the Inject method, it's easy to just have a struct that contains your options as fields. It's a nice feature of the code, since you maintain readability by having field names matching with the values (you should see some of the constructors in kubernetes with identical parameter types next to each other and no indication of what they are when reading the calling code). You can also achieve that with an "options struct" pattern, mostly.