Coder Social home page Coder Social logo

Comments (6)

seans3 avatar seans3 commented on August 15, 2024

Hi @fsommar . Server-side dry-run requires an APIServer version >= 1.16 (it requires server-side apply which is turned on by default in 1.16). Since we can not assume the APIServer version is >= 1.16 (e.g. GKE is in the range of 1.14 - 1.16, with 1.17 as the rapid channel), we must continue to use client-side apply functionality. Once we can rely on server-side apply, we will change kpt live apply and kpt live preview to use server-side apply. I'm going to close this issue shortly.

from cli-utils.

seans3 avatar seans3 commented on August 15, 2024

...as far as the change needed (once we intend to make it), the import of kubectl does not need to change (since it is about 1.18). But we'll need to update the ApplyOptions to fill in the server-side flags.

from cli-utils.

fsommar avatar fsommar commented on August 15, 2024

Ok, that makes sense. I saw that there were some server-side-apply-related flags, and figured that maybe at least the server-side dry-run could be exposed as a hidden flag? I created a PR for this in case that'd be an acceptable short-term fix.

from cli-utils.

fejta-bot avatar fejta-bot commented on August 15, 2024

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

from cli-utils.

fsommar avatar fsommar commented on August 15, 2024

I'll close this and then revisit it in the future when GKE is on more recent versions of Kubernetes.

/close

from cli-utils.

k8s-ci-robot avatar k8s-ci-robot commented on August 15, 2024

@fsommar: Closing this issue.

In response to this:

I'll close this and then revisit it in the future when GKE is on more recent versions of Kubernetes.

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

from cli-utils.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.