Coder Social home page Coder Social logo

Comments (11)

pwittrock avatar pwittrock commented on July 24, 2024 1

@metmajer Yup pretty sure that is it. Verifying now. #155

from apiserver-builder-alpha.

metmajer avatar metmajer commented on July 24, 2024

I have just verified that the same issue exists with the latest archives appended to the GitHub release v0.1-alpha.15. @pwittrock: as mentioned in #150, your change in #152 may not be needed. The error I had described around running apiserver-builder-release vendor was due to glide being missing on my system at that point in time.

from apiserver-builder-alpha.

pwittrock avatar pwittrock commented on July 24, 2024

@metmajer That is weird. Someone else just noticed the same thing.

Must have introduced a regression at some point. I suspect the issue is something in this code. If you feel comfortable, would you want to take a look? Otherwise, I will try to take a look this weekend.

from apiserver-builder-alpha.

pwittrock avatar pwittrock commented on July 24, 2024

The glide issue is one I was worried about. :( Have been wanting to vendor glide into the project and invoke it directly instead of through exec. #117

from apiserver-builder-alpha.

metmajer avatar metmajer commented on July 24, 2024

Sure, let me have a look into it. I can't promise to have it fixed this weekend though.

from apiserver-builder-alpha.

metmajer avatar metmajer commented on July 24, 2024

@pwittrock there's logic related to creating golang binaries in apiserver-builder-release/main.go which I do not understand well enough yet. I fear that a fix of mine could introduce unwanted side effects.

A quick look shows that Build properly sets GOOS= and GOARCH= before invoking RunCmd. However, RunCmd then unsets and populates cmd.Env, which effectively strips the previously injected GOOS= and GOARCH=. Hope this helps!

from apiserver-builder-alpha.

pwittrock avatar pwittrock commented on July 24, 2024

Uploading alpha .16 now.

from apiserver-builder-alpha.

pwittrock avatar pwittrock commented on July 24, 2024

File #156 to prevent this in the future.

from apiserver-builder-alpha.

pwittrock avatar pwittrock commented on July 24, 2024

alpha.16

from apiserver-builder-alpha.

admilazz avatar admilazz commented on July 24, 2024

I'm not sure if this bug is back or if it's a new bug, but v1.12.alpha.2 seems to have this problem as well.

from apiserver-builder-alpha.

yue9944882 avatar yue9944882 commented on July 24, 2024

I'm not sure if this bug is back or if it's a new bug, but v1.12.alpha.2 seems to have this problem as well.

apologies, it's caused by a misconfiguration. release binaries refreshed.

from apiserver-builder-alpha.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.