Comments (8)
Agreed. We should only expose modules to developers when needed. Otherwise it might introduce additional maintenance efforts such as backwards compatibility and versioning of the new module.
from common.
from common.
I think, we should move away from low level controller mode so that code is easy to maintain and new devs will find it easy. However, difficulty is to ensure stability of the code base when doing the porting work.
from common.
I see. So let me prepare the reconciler.v1
package first. We can further discuss how to deal with the controller mode code.
from common.
Current library provides reconcile
logics. It's kind of neutral and we did some refactor last year to make it work with both low level controller (tf, mxnet) or high level reconciler (xgboost). It we plan to move to reconciler.v1
. Let's add more details what need to do in reconciler.v1
. Does it bring locking to specific framework like kubebuilder?
from common.
@zw0610 Are there tasks left? We need to determine whether to use controller.v1
or reconciler.v1
when we merge kubeflow/common to kubeflow/training-operator.
/cc @gaocegege @johnugeorge @terrytangyuan
ref: kubeflow/training-operator#1714
from common.
from common.
no. we shall keep controller.v1 in the merge given the minimal changes to
the code.
Makes sense. Let's switch to reconciler.v1
after we merge kubeflow/common to kubeflow/training-operator.
from common.
Related Issues (20)
- Proposal: Define a job type to track all kinds of jobs on the same cluster HOT 2
- Panic when controller restarts HOT 2
- Use fully-qualified labels HOT 11
- Fully-qualified labels migration tasks
- Cut release-0.4 branch and cut 0.4.0 tag HOT 8
- PR 135 makes replicaType updates hard HOT 3
- [chore] Upgrade PriorityClass to scheduling.k8s.io/v1 HOT 2
- Use Interface instead of lister/informer in controller HOT 3
- Missing methods in reconciler.v1 HOT 1
- Master fails to build HOT 4
- Enable GitHub action to build and test code HOT 9
- Limit the number of restarts under ExitCode restartPolicy HOT 5
- Encounter NIL Error when job in error stage with TTL value set
- pr 172 breaks training-operator HOT 6
- set podgroup failed when pytorchjob failed
- Add comment to Clean Policy and Restart Policy nums
- When `restartPolicy` is `ExitCode` and a pod is deleted (137), the entire TFJob will still be marked as failed. HOT 10
- cannot use "github.com/go-openapi/spec".Schema{...} (type "github.com/go-openapi/spec".Schema) as type "k8s.io/kube-openapi/pkg/validation/spec".Schema in field value HOT 1
- [Discuss] Archive Kubeflow/common repo HOT 3
- Deprecation notice: kubeflow/common repo will be archived in two weeks.
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from common.