Coder Social home page Coder Social logo

Comments (4)

supertylerc avatar supertylerc commented on June 12, 2024

I asked about this a few days ago. However, I think that there may be some things to consider. Creating an array of the files lines may be bad from a performance perspective. Chunking may be better, creating a smaller array, pushing the lines, and then going through the next X chunks. This is particularly true when the file contains entire configurations with comments.

This suggestion may fall under "premature optimization is the root of all evil", though. Take it with a grain of salt. :)

Also, as I require this feature for an upcoming project, I may implement it (crudely) and submit a PR with the change.

from netmiko.

ktbyers avatar ktbyers commented on June 12, 2024

I think we should probably keep it simple...just read in the whole file and parse it into a list.

I don't see the performance of chunking as mattering.

The performance that possibly matter is how long it takes to send a whole bunch of configuration commands since send_config_set() calls send_command() which will by default delay 1 second per command.

from netmiko.

supertylerc avatar supertylerc commented on June 12, 2024

I've written the code for this. I'll be submitting a PR later today or tomorrow.

from netmiko.

supertylerc avatar supertylerc commented on June 12, 2024

This is in #59.

from netmiko.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.