Comments (4)
I asked about this a few days ago. However, I think that there may be some things to consider. Creating an array of the files lines may be bad from a performance perspective. Chunking may be better, creating a smaller array, pushing the lines, and then going through the next X chunks. This is particularly true when the file contains entire configurations with comments.
This suggestion may fall under "premature optimization is the root of all evil", though. Take it with a grain of salt. :)
Also, as I require this feature for an upcoming project, I may implement it (crudely) and submit a PR with the change.
from netmiko.
I think we should probably keep it simple...just read in the whole file and parse it into a list.
I don't see the performance of chunking as mattering.
The performance that possibly matter is how long it takes to send a whole bunch of configuration commands since send_config_set() calls send_command() which will by default delay 1 second per command.
from netmiko.
I've written the code for this. I'll be submitting a PR later today or tomorrow.
from netmiko.
This is in #59.
from netmiko.
Related Issues (20)
- Problem connecting to TP-Link switch HOT 7
- Only commands less than 64 caharacters work (Mikrotik) HOT 12
- hp_comware H3C device which in RBM mode using send_config_set with netmiko.exceptions.ReadTimeout HOT 11
- HP Comware - Display arp - no output HOT 10
- Unable to send config via txt file on Juniper device using NetMiko. Below exception HOT 1
- SSH Session Disconnect Taking Long Time After Running TMOS Command! HOT 4
- Mikrotik RouterOS - Unable to file_transfer to devices lacking flash filesystems
- Mikrotik RouterOS - file_transfer to device fails verification (not waiting long enough) HOT 1
- Unexpected FortiOS Version encountered
- Pattern not detected: '[>#]' in output - TPLINK device HOT 6
- Performance improvement, support setting DEFAULT_WINDOW_SIZE HOT 6
- Issue with Zyxel GS1900 HOT 8
- Exception has occurred: ReadTimeout HOT 2
- Netmiko tools threading solution needs updated
- SSHDetect not working with Jumphost inbetween HOT 1
- Nokia SROS issue with return value in ["xx"] HOT 7
- Warning and error: syntax error, expecting ']' or <data>: [
- security: allow SessionLog object to be passed to session_log arg HOT 12
- Driver: adtran_os not fully working as intended...
- Slack invite HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from netmiko.