FASA pods have incorrect mass about realismoverhaul

[NathanKell]

Either basemass = -1 was missed in the tank definition (note that we should probably start switching to basemass = (the same as part.mass) .....), or origMass was specified in ModuleEngineConfigs (if it was, remove the origMass = foo line).

[jrandom]

I'm a bit fuzzy on what these mass settings are for. What happens if the baseMass=-1 line is removed? Is it supposed to just be the mass of the pod or just the tank inside the pod? And should origMass just be removed completely from ModuleEngineConfigs? (I've clones the repo from git, hence the questions. :) )

[NathanKell]

Both the fuel tank and the engine module of RealFuels have the ability to set the mass of the part to which they are added. Basemass should be set to either -1 (to entirely disable tank-based mass setting) or to the mass of the pod (probably better, which means the pod will have a minimum of that mass, plus the mass of all tanks added). origMass should be entirely removed, since we do not want the mass of the pod to be scaled based on thruster tech level.

[jrandom]

Now that I'm looking closely, I'm seeing this same basemass issue all over the place, even with non-FASA parts, and including stock parts.

[Felger]

Would you mind doing a once-over and correcting the issue? I'll include the Pull request in the next release, not sure I'll have time to work on it otherwise.

[jrandom]

With the base mass set to -1, the wrong mass gets used in the VAB (even though the mass displays correctly in the context window). Once the part is added, a wrong mass is used. There are so many base mass entries set to -1 (including a lot of parts I have removed from my setup) that I don't really know how to correct the issue. I can fix a few parts, but I don't have the bandwidth to do all of them. :(

[Felger]

Notepad++ can do a find and replace in all open files, if you have a list
I'll fix it.
On Nov 15, 2014 9:49 AM, "jrandom" [email protected] wrote:

With the base mass set to -1, the wrong mass gets used in the VAB (even
though the mass displays correctly in the context window). Once the part is
added, a wrong mass is used. There are so many base mass entries set to -1
(including a lot of parts I have removed from my setup) that I don't really
know how to correct the issue. I can fix a few parts, but I don't have the
bandwidth to do all of them. :(

—
Reply to this email directly or view it on GitHub
#40 (comment)
.

[jrandom]

If base mass is set to -1, the wrong mass is used in the VAB. If base mass is removed entirely, the wrong mass is used in the VAB. I'm not exactly sure what I can mass-replace with? (I have Notepad++, as it is an indispensable tool.)

[Felger]

Yeah, That should have probably occured to me. Well, at least it would have occured to me as I was doing it!

In any case, it'd at least find the instances of basemass= -1

[NathanKell]

Wait, no, as I said above the problem for those parts is not basemass = -1 but if they have origMass in the ModuleEngineConfigs for their RCS. basemass = -1 tells RealFuels to not change mass based on tankage, so basemass = -1 means that is not the cause of mass changes.

Search for origMass in all cfgs, and nuke the line if it's specified in a module on a pod, where you don't want the mass of the pod changed when you change what engine config its thrusters use.

[stratochief66]

Consistent with NathanKell's most recent comment, I have corrected the Gemini capsule's mass using basemass = -1

From the title of the thread, does that mean this issue is resolved now?

[NathanKell]

Yep!