Comments (2)
i'll look into this. a couple questions:
1, i noticed in the readme section not everything is translated to every language (like the code examples are, but the headlines, other strings are only translated to english + russian + french i believe), how should i proceed?
2, also an overlook on my part: i added 'hungarian' to the language list, should i add 'magyar' (hungarian in hungarian) instead?
3, should i just commit on the development branch, or should i create a topic branch?
+1, also i'm not sure if i need to refactor some things (i saw there were a couple new commits, haven't got the time to look into them yet, but there are some issues, like #38)
from numbers_and_words.
-
"but the headlines, other strings are only translated to english + russian + french i believe"
Yes, as only 4 languages have native language contributors, other haven't any contributor or haven't native contributor. Also It looks like a mess when there are more than 3 languages in headings. I like that there are instructions for every language, but sometimes want to remove unnecessary information, maybe several READMEs with links could be nice approach. We could discuss about this in issue #48.
-
Yes, 'magyar' preferred.
-
If there is only one commit you could push in development instead, in other cases create new branch with feature name. (I sometimes use git-flow for this task) In both cases don't forget to add a link to appropriate issue.
- #38 is temporary approach, it must be refactoring later. (ex.: Float#to_words is not language dependent function)
from numbers_and_words.
Related Issues (20)
- Fork? HOT 12
- Finish German support
- Numeric Fallback HOT 5
- Wrong dependencies management makes the gem require activesupport 5.0 thus Ruby 2.2.2 HOT 8
- Drop EOL'ed Rubies in Travis CI HOT 1
- Configure I18n.available_locales
- Support for Arabic HOT 3
- Crashing Spanish Translations HOT 2
- Support for Chinese? HOT 1
- Support for float numbers in french HOT 1
- Floating-point numbers with five or more digits after decimal separator
- Move this gem into a github org?
- Ability to add units
- Why included .yml languages as internal instead of document them and let user customize? HOT 2
- Wrong precision 2 for spanish HOT 1
- I18n::InvalidPluralizationData (translation data {:one=>"tenth", :other=>"tenths"} HOT 7
- Incorrect joiner for some Dutch examples HOT 3
- Problem with hundreds as array HOT 1
- Does this gem work with Ruby 3.2.0 ? HOT 1
- When the numbers start with 0 it showing incorrect string value. HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from numbers_and_words.