Coder Social home page Coder Social logo

Comments (2)

eLod avatar eLod commented on August 31, 2024

i'll look into this. a couple questions:

1, i noticed in the readme section not everything is translated to every language (like the code examples are, but the headlines, other strings are only translated to english + russian + french i believe), how should i proceed?
2, also an overlook on my part: i added 'hungarian' to the language list, should i add 'magyar' (hungarian in hungarian) instead?
3, should i just commit on the development branch, or should i create a topic branch?
+1, also i'm not sure if i need to refactor some things (i saw there were a couple new commits, haven't got the time to look into them yet, but there are some issues, like #38)

from numbers_and_words.

kslazarev avatar kslazarev commented on August 31, 2024
  1. "but the headlines, other strings are only translated to english + russian + french i believe"

    Yes, as only 4 languages have native language contributors, other haven't any contributor or haven't native contributor. Also It looks like a mess when there are more than 3 languages in headings. I like that there are instructions for every language, but sometimes want to remove unnecessary information, maybe several READMEs with links could be nice approach. We could discuss about this in issue #48.

  2. Yes, 'magyar' preferred.

  3. If there is only one commit you could push in development instead, in other cases create new branch with feature name. (I sometimes use git-flow for this task) In both cases don't forget to add a link to appropriate issue.

  • #38 is temporary approach, it must be refactoring later. (ex.: Float#to_words is not language dependent function)

from numbers_and_words.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.