API improvement suggestions about seismicmesh

[krober10nd]

Neat that's logical. Yea, corners could be optional as naturally some some geometries don't have them.

I'll get to work sometime today.

[nschloe]

Extrusion, yes, also a good idea. Gmsh has extrude, revolve, twist. For all of these, it's possible to create a 3D model from a 2D one programmatically. That's for the future perhaps.

[krober10nd]

A tuple as opposed to a list? Why so strict? (Genuine question, perhaps it does make sense.)

Because tuple is immutable and the idea is that the bbox shouldn't mutate.

[krober10nd]

Okay made some progress over on #106 ....will add the intersection class in a bit. One thing that I'd like to handle is if you want to compute the intersection between say a disk (dim=2) and a cube (dim=3), it could work it out and produce a cylinder.

Maybe the latter isn't a great idea, not sure.

[nschloe]

intersection between say a disk (dim=2) and a cube (dim=3)

Doesn't seem to make sense when first reading it.

I'd say better get union, intersection, and difference down. Perhaps a few primitive shapes like cube, ball, wedge, I don't know. With this, one should be able to do quite a lot already.

[krober10nd]

Yea, I agree. I think that's more of what you would call an extrusion.

[jorgensd]

Another minor improvement would be to have an additional keyword argument to plot_sizing_function, such that one can visualize it when using containers etc.

def plot_sizing_function(cell_size, stride=1, comm=None, filename=None):
    # ...
    if filename is None:
        plt.show()
    else:
        plt.savefig(filename)

[krober10nd]

ah yea, that's a good suggestion.

[nschloe]

The following still fails

import SeismicMesh

points, cells = SeismicMesh.generate_mesh(
    h0=0.1,
    domain=SeismicMesh.geometry.Rectangle([-1.0, +1.0, -1.0, +1.0]),
    edge_length=0.1,
)

ValueError: `bbox` must be a tuple

The idea here would be that you don't need to specify a bbox explicitly; it should be taken from domain.

[krober10nd]

The idea here would be that you don't need to specify a bbox explicitly; it should be taken from domain.

It is taken from domain.

SeismicMesh/SeismicMesh/generation/mesh_generator.py

Line 136 in d71ccee

fd, bbox0, _ = _unpack_domain(domain, sliver_opts)

It's failing because bbox isn't a tuple

[nschloe]

A tuple as opposed to a list? Why so strict? (Genuine question, perhaps it does make sense.)

[krober10nd]

This should work

 import SeismicMesh
 
 points, cells = SeismicMesh.generate_mesh(
     domain=SeismicMesh.geometry.Rectangle((-1.0, +1.0, -1.0, +1.0)),
     edge_length=0.1,
 )

[nschloe]

Can perhaps also be closed.