Coder Social home page Coder Social logo

Type issues about kanel HOT 3 CLOSED

dmoose avatar dmoose commented on August 16, 2024
Type issues

from kanel.

Comments (3)

dmoose avatar dmoose commented on August 16, 2024

Just read your comment to issue 3. That looks like it would work to fix the additional types like Macaddr etc. Just define them one level up and add a comment. A little extra work making sure the comments are where they need to be. The assumption about id being a number looks a little harder to work around.

from kanel.

kristiandupont avatar kristiandupont commented on August 16, 2024

Ah yes, this is a symptom of the fact that I just extracted the code from a larger project, so these are cases that aren't covered yet. I think maybe type-comments would help but for this case, it seems more like you should be able to specify type mappings in the configuration file. I will look into that today.

ID's being hardcoded as numbers is a clear bug, they should extract the type of the column obviously. And yes, that might be slightly more difficult to fix but I will dig into that as well :-)

from kanel.

kristiandupont avatar kristiandupont commented on August 16, 2024

I've just published a new version that fixes the id-type bug.

As for custom type mappings, it turns out that I had already implemented it, just not documented it yet. You can specify custom types in the customTypeMap config property. Note that it doesn't add import statements yet, so it will only work with primitives. It should probably be expanded.

from kanel.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.