Comments (9)
The ordering works the same way as in express. So :id
param matches everything and next route will not be called. Playground: https://jsfiddle.net/frenzzy/ko22k9cg/
from universal-router.
Yes, because the action
method of a route will have to return anything different from undefined
to stop iterating and finish routing process.
const anyRoute = {
path: '/'
action() {
if (condition) {
return undefined // skip this route
}
return 'page'
}
}
Playground: https://jsfiddle.net/frenzzy/ko22k9cg/1/
from universal-router.
const container = document.getElementById('root');
function render(component) {
return Promise((resolve, reject) => {
try {
ReactDOM.render(component, container, () => resolve(true /* something not falsy */));
} catch (err) { reject(err); }
});
}
from universal-router.
Router waits until your promise will be finished and if promise returns undefined
Router skips current route.
from universal-router.
@koistya that corrects the issue, thanks! Would be good to include this in documentation.
from universal-router.
By the way I think it is much better to start render strictly after the navigation process completely finished. This will help to avoid a lot of troubles like this and make the code easier to understand.
const routes = [
{ path: '/one', action() { return <div>One</div> } },
{ path: '/two', action() { return <div>Two</div> } },
{ path: '/*', action() { return <div>Not Found</div> } },
];
UniversalRouter
.resolve(routes, { path: '/one' })
.then(component =>
ReactDOM.render(component, document.getElementById('root'))
)
Playground:
- https://jsfiddle.net/frenzzy/ko22k9cg/3/
- https://jsfiddle.net/frenzzy/ko22k9cg/4/
- https://jsfiddle.net/frenzzy/ko22k9cg/5/
from universal-router.
@frenzzy you're right routes are resolved top->bottom, and after further investigation my problem is different. It look like route matching is not stopped after first matched route. so with
const routes = [
{ path: '/welcome', name: 'welcome' },
{ path: '/sign_in', name: 'signIn' },
{ path: '/:id', name: 'idRoute' }
];
and path /welcome
it matches both /welcome
and /:id
from universal-router.
I followed example from docs
const routes = [
{ path: '/one', action: ({ render }) => render(<h1>Page One</h1>) },
{ path: '/two', action: ({ render }) => render(<h1>Page Two</h1>) }
];
function render(component) {
return Promise(resolve => {
ReactDOM.render(component, document.body, resolve);
});
}
so all of my actions are returning Promise
but still this error appears.
from universal-router.
Closing this as resolved. Please reopen if needed.
from universal-router.
Related Issues (20)
- bad documentation in 'Getting Started' page HOT 1
- How does universal router handle conflicts? HOT 1
- Question: Routing based on backend logic HOT 3
- Synchronous operation HOT 3
- Recipe for GraphQL state management vs. Redux would be great HOT 1
- middleware TypeError for not found routes HOT 1
- Getting child route's params in middleware HOT 2
- generateUrls() does not work with universal-router/sync HOT 2
- Update Hyperapp url in README
- BUG: route dose not resolve ? HOT 2
- overriding Route type when initializing UniversalRouter HOT 5
- update path-to-router dependency to latest HOT 1
- TypeScript 3.8.3: type checking failing HOT 9
- Incorrect TypeScript RouteParams Interface HOT 2
- Middlware approach context.next and redirection HOT 2
- Bug: Empty children array shouldnt be required when dynamically defining routes HOT 2
- Nested url generation HOT 2
- Simple Change: Make resolveRoute a class member of UniversalRouter instead of privately scoped HOT 1
- how to handle "not found (404)" page? HOT 1
- Redirects?? HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from universal-router.