Coder Social home page Coder Social logo

Comments (13)

boonep avatar boonep commented on May 8, 2024 3

Any word on this? I've come across the same issue with RSK. Thanks!

from universal-router.

chilic avatar chilic commented on May 8, 2024 2

@dreambo8563
Look at action method:

  async action({ next }) {
    const component = await next();
    return component;
  },

from universal-router.

frenzzy avatar frenzzy commented on May 8, 2024 2

The right way here is:

const routes = {
  path: '/users', // base url
  children: [
    {
      path: '/', // main page
      action() { return 'User List' }
    },
    {
      path: '/:id', // child page
      action(context) { return `User #${context.params.id}` }
    },
  ]
};

Playground: https://jsfiddle.net/frenzzy/o50uu79q/

from universal-router.

vishwanatharondekar avatar vishwanatharondekar commented on May 8, 2024 2

@frenzzy Above solution given works as expected. It will be great if we could get a warning that children route and parent action are available together. Easy to do this mistake for user of the router.

from universal-router.

koistya avatar koistya commented on May 8, 2024 1

Child routes should work in react-starter-kit out of the box. I will test your use case in RSK..

from universal-router.

chilic avatar chilic commented on May 8, 2024 1

I found solution:
Parent route should be like

export default {
  path: '/parent',

  async action({ next }) {
    const component = await next();
    return component;
  },

  children: [
    {
      path: '/', // Same as "/parent"
      action: async () => <ParentComponent />,
    },
    childRoute, // Will be "/parent/child"
  ],
};

from universal-router.

koistya avatar koistya commented on May 8, 2024

@Dmitry-N-Medvedev resolve(routes, { path: '/clients/123' })?

from universal-router.

Dmitry-N-Medvedev avatar Dmitry-N-Medvedev commented on May 8, 2024

I'm using react-starter-kit... Do I require to make changes to it to have child routes operational?

from universal-router.

dreambo8563 avatar dreambo8563 commented on May 8, 2024

I got the same issue, children router not working

from universal-router.

dreambo8563 avatar dreambo8563 commented on May 8, 2024

@chilic not working for me:

export default {

  path: '/contact',

  async action() {
    const Contact = await new Promise((resolve) => {
      require.ensure([], (require) => resolve(require('./Contact').default));
    });


    return <Contact />;
  },
  children: [
    {
      path: '/', // Same as /parent
      action: () => <Contact />,
    },
    {
      path: '/contact/name', // Same as /parent
      action: async () => {
        console.log('in name router')
        return <h1>good</h1>
      },
    },
  ],

};

from universal-router.

dreambo8563 avatar dreambo8563 commented on May 8, 2024

@chilic you save my world

this works

export default {

  path: '/contact',

  // async action() {
  //   const Contact = await new Promise((resolve) => {
  //     require.ensure([], (require) => resolve(require('./Contact').default));
  //   });


  //   return <Contact />;
  // },
  async action({ next }) {
    const component = await next();
    return component;
  },
  children: [
    {
      path: '/', // Same as /parent
      action: () => <Contact />,
    },
    {
      path: '/name',
      action: async () => {
        console.log('in name router')
        return (
          <div>
            <h1>good</h1>
            <Contact />
          </div>
        )
      },
    },
  ],

};

from universal-router.

frenzzy avatar frenzzy commented on May 8, 2024

This should be fixed, please reopen if necessary.

from universal-router.

vishwanatharondekar avatar vishwanatharondekar commented on May 8, 2024

Solution given by @chilic works but this needs to be solved. I guess for this to work, child route must be resolved before parent route, when both child and parent routes are available.

from universal-router.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.