Comments (13)
Any word on this? I've come across the same issue with RSK. Thanks!
from universal-router.
@dreambo8563
Look at action method:
async action({ next }) {
const component = await next();
return component;
},
from universal-router.
The right way here is:
const routes = {
path: '/users', // base url
children: [
{
path: '/', // main page
action() { return 'User List' }
},
{
path: '/:id', // child page
action(context) { return `User #${context.params.id}` }
},
]
};
Playground: https://jsfiddle.net/frenzzy/o50uu79q/
from universal-router.
@frenzzy Above solution given works as expected. It will be great if we could get a warning that children route and parent action are available together. Easy to do this mistake for user of the router.
from universal-router.
Child routes should work in react-starter-kit out of the box. I will test your use case in RSK..
from universal-router.
I found solution:
Parent route should be like
export default {
path: '/parent',
async action({ next }) {
const component = await next();
return component;
},
children: [
{
path: '/', // Same as "/parent"
action: async () => <ParentComponent />,
},
childRoute, // Will be "/parent/child"
],
};
from universal-router.
@Dmitry-N-Medvedev resolve(routes, { path: '/clients/123' })
?
from universal-router.
I'm using react-starter-kit... Do I require to make changes to it to have child routes operational?
from universal-router.
I got the same issue, children router not working
from universal-router.
@chilic not working for me:
export default {
path: '/contact',
async action() {
const Contact = await new Promise((resolve) => {
require.ensure([], (require) => resolve(require('./Contact').default));
});
return <Contact />;
},
children: [
{
path: '/', // Same as /parent
action: () => <Contact />,
},
{
path: '/contact/name', // Same as /parent
action: async () => {
console.log('in name router')
return <h1>good</h1>
},
},
],
};
from universal-router.
@chilic you save my world
this works
export default {
path: '/contact',
// async action() {
// const Contact = await new Promise((resolve) => {
// require.ensure([], (require) => resolve(require('./Contact').default));
// });
// return <Contact />;
// },
async action({ next }) {
const component = await next();
return component;
},
children: [
{
path: '/', // Same as /parent
action: () => <Contact />,
},
{
path: '/name',
action: async () => {
console.log('in name router')
return (
<div>
<h1>good</h1>
<Contact />
</div>
)
},
},
],
};
from universal-router.
This should be fixed, please reopen if necessary.
from universal-router.
Solution given by @chilic works but this needs to be solved. I guess for this to work, child route must be resolved before parent route, when both child and parent routes are available.
from universal-router.
Related Issues (20)
- bad documentation in 'Getting Started' page HOT 1
- How does universal router handle conflicts? HOT 1
- Question: Routing based on backend logic HOT 3
- Synchronous operation HOT 3
- Recipe for GraphQL state management vs. Redux would be great HOT 1
- middleware TypeError for not found routes HOT 1
- Getting child route's params in middleware HOT 2
- generateUrls() does not work with universal-router/sync HOT 2
- Update Hyperapp url in README
- BUG: route dose not resolve ? HOT 2
- overriding Route type when initializing UniversalRouter HOT 5
- update path-to-router dependency to latest HOT 1
- TypeScript 3.8.3: type checking failing HOT 9
- Incorrect TypeScript RouteParams Interface HOT 2
- Middlware approach context.next and redirection HOT 2
- Bug: Empty children array shouldnt be required when dynamically defining routes HOT 2
- Nested url generation HOT 2
- Simple Change: Make resolveRoute a class member of UniversalRouter instead of privately scoped HOT 1
- how to handle "not found (404)" page? HOT 1
- Redirects?? HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from universal-router.