Comments (2)
I agree the throw
is unreachable. That may just be an artifact of making Flow happy (since document.body
is always an optional in Flow, throwing is the only way to make Flow happy that we are returning a definite HTMLBodyElement
type rather than a ?HTMLBodyElement
).
That said; I don't think we can change the behavior of waitForDocumentReady
or isDocumentReady
at this point, to not depend on document.body
being present. That can be changed in a new major version of belter -- but if we remove that now, that is likely to be breaking behavior.
from belter.
Yes, and to avoid that I could remove the conditional statement. Because if waitForDocumentReady
has resolved that means document.body
has to be present. That could make flow happy.
I agree with you on the second part. Changing waitForDocumentReady
or isDocumentReady
would cause breaking changes.
from belter.
Related Issues (11)
- Add unit tests that test exported functions in src/ HOT 13
- Create a CHANGELOG.md file
- Issue running the tests
- Updating versions in package.json file
- Structure of tests are confusing HOT 1
- chai, sinon, and sinon-chai should be included in dependencies HOT 1
- Linting checks are failing HOT 1
- consider not rounding dimensions in onResize method
- isSafari allows Chromium browser Yandex through
- Create TypeScript typings HOT 10
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from belter.