Trayicon doesn't disappear / Syncthing restart issue about syncthing-gtk

[kozec]

The systray icon doesn't go away upon exiting Syncthing-GTK.

I'm aware of this, but I have yet to find way how to tell Windows to remove icon... It looks like it doesn't remove it automatically even if process owning icon exits.

Well... it just opens a "Connection was lost" window with the "Quit" button and ... that's it.

This may happen if daemon is restarting for too long, mainly because "Connection was lost" will not disappear even if connection is restored. I should probably fix that :D

I'm aware of this, but I have yet to find way how to tell Windows to remove icon...
It looks like it doesn't remove it automatically even if process owning icon exits.

Well, generally speaking: You need a "OnClose()" handler to send it a "NIM_DELETE" event. Maybe take a look at http://msdn.microsoft.com/en-us/library/windows/desktop/bb762159%28v=vs.85%29.aspx where they explain the Shell_NotifyIcon function.

[kozec]

Well, I'm using Gtk.StatusIcon here, so I probably can't use native Windows API around it. But I probably can make icon invisible before exiting, so there may be "occupied" space left in systray, but without Syncthing icon.

Yea, that's the problem. Due to making it "cross platform" you don't really interact with the win32api class you would need to properly talk to Windows - and splitting the code into 'if platform.system="Linux"' and 'if platform.system="Windows"' sections would only add tons of complexity.

Hiding the icon / making it invisible upon exit sounds like the best idea by looking at the pygtk class reference - since there's obviously no way to explicitly "remove" or "destroy" the icon.

[kozec]

Well, source is full of if IS_WINDOWS: do_something_crazy() anyway, but there is no chance I'm going to do third trayicon implementation with WinAPI :)

Ok, zombie icon should be gone now, I'll look to 2nd problem later or tomorow.