Comments (4)
You shouldn't need to change access_disabled. You can set the prop like any other rom, and in fact would also work on stock. It's just a persist.sys setting.
from superuser.
But only if you have an "ro.cm.version" property set .. all the code in access_disabled() is skipped without it, preventing the specific Apps/ADB Access conditions from being checked at all.
I was thinking more about ROMs that would still like to have the Access settings to be functional, but don't necessarily follow all of the same rules as CM. I like to keep ro.debuggable set to "0" on all builds, for example. Based on the current code, even if I set an "ro.cm.version" property to something fake to enable the checks, all su access would just be denied because ro.debuggable is not "1". Stuff like that .... little differences that would break or limit some functionality.
No worries either way, this new Superuser is pretty fantastic as-is, and being 100% public it's just a couple clicks to fork and change the behavior slightly for different environments. Just thought it might be something that would come in handy and potentially reduce the amount of out-of-baseline code out there.
from superuser.
Oh, I did not realize there was an ro.cm.version check; that is unnecessary (and vestigal code from the port). I've removed it and will check it in shortly.
from superuser.
Yeah, I'll need to mess with this to handle defaults in CM vs the rest of the world. I'll fix this to accomodate your suggestions. I didn't realize this was completely busted on non-cm.
from superuser.
Related Issues (20)
- hi
- SU HOT 1
- [wiki] Add page explaining how to replace other root manager apps with Superuser HOT 1
- Oreo 8.1, Magish, addonsu, SR5superSUv2.82SystemMode, SU binary occupied error on SuperSU Pro HOT 10
- F-Droid HOT 2
- SU
- SU
- Restart by Recovery HOT 1
- user
- Super user HOT 2
- Drl
- 2e5cf1978193997806df583285f6660702a8af79
- www.supersu.com HOT 4
- Superuser
- Su
- wire shark
- Falcotek
- Replace Superuser With Magsik?
- 55hhb
- > The option to restart by recovery is broken because when you press it the cell restart to go to recovery but when you go to call again to go to the system it doesn't turn on(fix this please i can't turn off my cell phone because of this)This option is from the Rom manager
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from superuser.